From 58a9182f524af15982817a27439c90a1fc66afe2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Hordy=C5=84ski?= Date: Mon, 9 Dec 2024 13:08:09 +0100 Subject: [PATCH 1/4] fix: evaluation pipeline should return all element types --- .../src/ragbits/evaluate/pipelines/document_search.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py b/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py index c1cf35cb9..666e7d485 100644 --- a/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py +++ b/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py @@ -50,7 +50,7 @@ async def __call__(self, data: dict) -> DocumentSearchResult: The evaluation result. """ elements = await self.document_search.search(data["question"]) - predicted_passages = [element.content for element in elements if isinstance(element, TextElement)] + predicted_passages = [element.text_representation for element in elements] return DocumentSearchResult( question=data["question"], reference_passages=data["passages"], From 12f9db75284eb0e673e1fe0e12566b702ecf2926 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Hordy=C5=84ski?= Date: Mon, 9 Dec 2024 13:08:35 +0100 Subject: [PATCH 2/4] fix imports --- .../src/ragbits/evaluate/pipelines/document_search.py | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py b/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py index 666e7d485..6359788f4 100644 --- a/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py +++ b/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py @@ -8,7 +8,6 @@ from ragbits.document_search import DocumentSearch from ragbits.document_search.documents.document import DocumentMeta -from ragbits.document_search.documents.element import TextElement from ragbits.document_search.documents.sources import HuggingFaceSource from ragbits.evaluate.pipelines.base import EvaluationPipeline, EvaluationResult From ba86a09a65de3e54e1f6e20af378a70c8cce16e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Hordy=C5=84ski?= Date: Mon, 9 Dec 2024 13:11:12 +0100 Subject: [PATCH 3/4] fix type --- .../src/ragbits/evaluate/pipelines/document_search.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py b/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py index 6359788f4..6b15b46fd 100644 --- a/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py +++ b/packages/ragbits-evaluate/src/ragbits/evaluate/pipelines/document_search.py @@ -49,7 +49,7 @@ async def __call__(self, data: dict) -> DocumentSearchResult: The evaluation result. """ elements = await self.document_search.search(data["question"]) - predicted_passages = [element.text_representation for element in elements] + predicted_passages = [element.text_representation or "" for element in elements] return DocumentSearchResult( question=data["question"], reference_passages=data["passages"], From 90d36d705bc7e16f0b33486bfa033e40ec821b49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Hordy=C5=84ski?= Date: Mon, 9 Dec 2024 13:16:05 +0100 Subject: [PATCH 4/4] add changelog --- packages/ragbits-evaluate/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/ragbits-evaluate/CHANGELOG.md b/packages/ragbits-evaluate/CHANGELOG.md index 7b3a2db35..fb6bb3be7 100644 --- a/packages/ragbits-evaluate/CHANGELOG.md +++ b/packages/ragbits-evaluate/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Changed + +- document search evaluation now returns all Element types, rather than only TextElements (#241). + ## 0.5.0 (2024-12-05) ### Changed