Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Massimiliano Pippi <[email protected]>
  • Loading branch information
anakin87 and masci authored Dec 22, 2023
1 parent 017cd75 commit f42c540
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion integrations/pinecone/tests/test_document_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def test_init(self, mock_pinecone):
assert document_store.batch_size == 50
assert document_store.dimension == 30
assert document_store.index_creation_kwargs == {"metric": "euclidean"}
assert document_store.api_key == "fake-api-key"

@patch("pinecone_haystack.document_store.pinecone")
def test_init_api_key_in_environment_variable(self, monkeypatch):
Expand All @@ -55,7 +56,7 @@ def test_init_api_key_in_environment_variable(self, monkeypatch):
metric="euclidean",
)

assert True
assert document_store.api_key == "fake-api-key"

def test_init_fails_wo_api_key(self, monkeypatch):
api_key = None
Expand Down

0 comments on commit f42c540

Please sign in to comment.