From f42c54080d12d34b5f304c66d0c32aa726a073af Mon Sep 17 00:00:00 2001 From: Stefano Fiorucci Date: Fri, 22 Dec 2023 11:40:41 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Massimiliano Pippi --- integrations/pinecone/tests/test_document_store.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/integrations/pinecone/tests/test_document_store.py b/integrations/pinecone/tests/test_document_store.py index 01017d67f..9f0db402b 100644 --- a/integrations/pinecone/tests/test_document_store.py +++ b/integrations/pinecone/tests/test_document_store.py @@ -41,6 +41,7 @@ def test_init(self, mock_pinecone): assert document_store.batch_size == 50 assert document_store.dimension == 30 assert document_store.index_creation_kwargs == {"metric": "euclidean"} + assert document_store.api_key == "fake-api-key" @patch("pinecone_haystack.document_store.pinecone") def test_init_api_key_in_environment_variable(self, monkeypatch): @@ -55,7 +56,7 @@ def test_init_api_key_in_environment_variable(self, monkeypatch): metric="euclidean", ) - assert True + assert document_store.api_key == "fake-api-key" def test_init_fails_wo_api_key(self, monkeypatch): api_key = None