release chroma on python 3.8 (#512)

* release chroma on python 3.8 * also run tests on 3.8 * fix test * retry wo pipe --------- Co-authored-by: anakin87 <[email protected]>
deepset-ai · Mar 1, 2024 · fb2bcd6 · fb2bcd6
1 parent 7a3b7bf
commit fb2bcd6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/chroma.yml b/.github/workflows/chroma.yml
@@ -30,7 +30,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        python-version: ['3.9', '3.10']
+        python-version: ['3.8', '3.9', '3.10']
 
     steps:
     - name: Support longpaths

diff --git a/integrations/chroma/pyproject.toml b/integrations/chroma/pyproject.toml
@@ -7,7 +7,7 @@ name = "chroma-haystack"
 dynamic = ["version"]
 description = ''
 readme = "README.md"
-requires-python = ">=3.9"
+requires-python = ">=3.8"
 license = "Apache-2.0"
 keywords = []
 authors = [
@@ -16,6 +16,7 @@ authors = [
 classifiers = [
   "Development Status :: 4 - Beta",
   "Programming Language :: Python",
+  "Programming Language :: Python :: 3.8",
   "Programming Language :: Python :: 3.9",
   "Programming Language :: Python :: 3.10",
   "Programming Language :: Python :: 3.11",

diff --git a/integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py b/integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py
@@ -315,7 +315,8 @@ def _normalize_filters(filters: Dict[str, Any]) -> Tuple[List[str], Dict[str, An
         for k in keys_to_remove:
             del filters[k]
 
-        final_where = dict(filters | where)
+        final_where = dict(filters)
+        final_where.update(dict(where))
         try:
             if final_where:
                 validate_where(final_where)