Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a separate folder for each component type under integrations #100

Closed
17 tasks done
bilgeyucel opened this issue Dec 13, 2023 · 1 comment
Closed
17 tasks done
Assignees
Labels
feature request Ideas to improve an integration P1

Comments

@bilgeyucel
Copy link
Contributor

bilgeyucel commented Dec 13, 2023

Is your feature request related to a problem? Please describe.
As a user, I'm familiar with the convention at haystack repository and having the same convention here would make it easy for me to navigate.

Describe the solution you'd like
Create a /generators folder under cohere_haystack integration folder.
The same can apply to jina_haystack and unstructured. This way, we can be more open to new components coming from the same providers

Describe alternatives you've considered
We can leave it as it is.

Additional context
N/A

Tasks

Preview Give feedback
  1. P1 integration:amazon-bedrock
    vblagoje
  2. P1 integration:astra
    masci
  3. P1 integration:cohere
    vblagoje
  4. P1 integration:elasticsearch
    masci
  5. P1 integration:google-ai
    masci
  6. P1 integration:google-vertex
    masci
  7. 1 of 1
    P1 integration:gradient
    masci
  8. P1 integration:instructor-embedders
    masci
  9. P1 integration:jina
    masci
  10. P1 integration:llama_cpp
    anakin87
  11. P1 integration:ollama
    anakin87
  12. 1 of 1
    P1 integration:opensearch
    masci
  13. P1 integration:pinecone
    masci
  14. P1 integration:qdrant
    masci
  15. P1 integration:unstructured-fileconverter
    anakin87
  16. P1 integration:weaviate
    silvanocerza
  17. integration:chroma
    masci
@bilgeyucel bilgeyucel added the feature request Ideas to improve an integration label Dec 13, 2023
@masci masci added the P1 label Dec 19, 2023
@masci masci self-assigned this Jan 8, 2024
@masci
Copy link
Contributor

masci commented Jan 12, 2024

We're going to uniform the import path of all the integrations under the namespace haystack_integrations.*.

For example, this means that a document store FooDocumentStore shipped with the integration baz-haystack will be imported like this:

from haystack_integrations.document_stores.baz import FooDocumentStore

Similarly, a generator AwesomeGenerator shipped with the integration foo-haystack will be imported like this:

from haystack_integrations.components.generators.foo import AwesomeGenerator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas to improve an integration P1
Projects
None yet
Development

No branches or pull requests

2 participants