Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opensearch retrievers docstrings show the old filters syntax #1017

Closed
anakin87 opened this issue Aug 23, 2024 · 0 comments · Fixed by #1035
Closed

Opensearch retrievers docstrings show the old filters syntax #1017

anakin87 opened this issue Aug 23, 2024 · 0 comments · Fixed by #1035
Labels
contributions wanted! Looking for external contributions good first issue Good for newcomers integration:opensearch P3 type:documentation Improvements or additions to documentation

Comments

@anakin87
Copy link
Member

anakin87 commented Aug 23, 2024

retriever.run(query="Why did the revenue increase?",
filters={"years": ["2019"], "quarters": ["Q1", "Q2"]})

This is just an example, but we should also check the Embedding Retriever and replace the examples with others showing the new filters syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions wanted! Looking for external contributions good first issue Good for newcomers integration:opensearch P3 type:documentation Improvements or additions to documentation
Projects
Development

Successfully merging a pull request may close this issue.

1 participant