Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ChatRoles in responses returned by ChatGenerators #1026

Closed
Amnah199 opened this issue Aug 27, 2024 · 0 comments · Fixed by #1030
Closed

Check ChatRoles in responses returned by ChatGenerators #1026

Amnah199 opened this issue Aug 27, 2024 · 0 comments · Fixed by #1030
Assignees
@Amnah199
Labels
bug Something isn't working

Comments

@Amnah199
Copy link
Contributor

Describe the bug
Certain ChatGenerator instances are incorrectly returning responses from the model with a system role. This is pointed out by @anakin87 in the GoogleGeminiGenerator.

To Reproduce
Use the GoogleGeminiGenerator to generate responses.

Describe your environment (please complete the following information):

  • OS: iOS
  • Haystack version: 2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amnah199 Amnah199

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: chat roles for model responses in chat generators deepset-ai/haystack-core-integrations
1 participant
@Amnah199