QdrantDocumentStore type errors when adding to DocumentWriter

[jscheel]

Describe the bug

"QdrantDocumentStore" is incompatible with protocol "DocumentStore"
    "write_documents" is an incompatible type
      Type "(documents: List[Document], policy: DuplicatePolicy = DuplicatePolicy.FAIL) -> (int | None)" cannot be assigned to type "(documents: List[Document], policy: DuplicatePolicy = DuplicatePolicy.NONE) -> int"
        Function return type "int | None" is incompatible with type "int"
          Type "int | None" cannot be assigned to type "int"
    "delete_documents" is an incompatible type
      Type "(ids: List[str]) -> None" cannot be assigned to type "(document_ids: List[str]) -> None"
        Parameter name mismatch: "document_ids" versus "ids"

To Reproduce
Run type-checking on this code:

from haystack_integrations.document_stores.qdrant import QdrantDocumentStore
from haystack.components.writers import DocumentWriter

store = QdrantDocumentStore()
writer = DocumentWriter(store)

Describe your environment (please complete the following information):

• OS: macOS 14.5
• Haystack version: 2.4.0
• Integration version: 4.2.0

[anakin87]

I agree, these are bugs. Thanks for reporting them.
Luckily, they do not seem hard to fix.

Would you like to open a PR?
Let us know... Otherwise, we will fix them soon.

[jscheel]

Sure, I’ll take a look at it.

…

On Fri, Aug 30, 2024 at 3:18 AM Stefano Fiorucci ***@***.***> wrote: I agree, these are bugs. Thanks for reporting them. Luckily, they do not seem hard to fix. Would you like to open a PR? Let us know... Otherwise, we will fix them soon. — Reply to this email directly, view it on GitHub <#1039 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABTUFRDATFZ7TFOSJNZN7LZUATEBAVCNFSM6AAAAABNLI67MSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRQGQ2TGMBZGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jscheel]

Submitted a quick PR. Please note that it technically has a breaking change because of an argument name change.