Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecone-python-client v3.0.0 breaks pinecone-haystack #223

Closed
awinml opened this issue Jan 16, 2024 · 5 comments
Closed

Pinecone-python-client v3.0.0 breaks pinecone-haystack #223

awinml opened this issue Jan 16, 2024 · 5 comments
Assignees
Labels
bug Something isn't working integration:pinecone P3

Comments

@awinml
Copy link
Contributor

awinml commented Jan 16, 2024

Describe the bug

The version 3.0.0 of pinecone-python-client is a big update and introduces a lot of changes. This new version is not compatible with the current implementation of pinecone-haystack and the code breaks as soon as you try to initialize the document store.

To Reproduce

The global pinecone.init has been removed, so pinecone-haystack gives an error as soon as you try to initialize the document store with the new version of pinecone-python-client.

Please see this Colab notebook for more information.

Immediate Fix

Pin pinecone-client to version 2.2.4 in the pinecone-haystack dependencies.

Describe the solution you'd like

Refactor pinecone-haystack to support the new version.

The new version introduces a lot of new features. Some of the changes include:

  • Serverless indexes
  • Global state variables set with pinecone.init have been refactored into new Pinecone class instances that encapsulate their configuration state.
  • Everything GRPC-related is now moved into a subpackage, pinecone.grpc, so that GRPC code is only imported when needed.
  • The list_indexes and list_collections methods now return an array with full descriptions of each resource, not merely an array of names.
  • The Pinecone SDK now has a Apache 2.0 license.

Please see the Migration Guide for version 3.0.0 for more information.

Describe your environment:

  • OS: Linux
  • Haystack version: haystack-ai - 2.0.0-beta.4
  • Integration version: pinecone-haystack - 0.0.1
@awinml awinml added the bug Something isn't working label Jan 16, 2024
@anakin87
Copy link
Member

Thank you for reporting this!

I would adopt the immediate fix and then refactor the Document Store.

@masci
Copy link
Contributor

masci commented Jan 17, 2024

0.1.0 was released to ship the temporary workaround

@bilgeyucel
Copy link
Contributor

We can resolve #715 with this upgrade

@mmurraysans
Copy link

Hi All,

I took a pass at updating this to the new client in #756

@anakin87
Copy link
Member

anakin87 commented Jun 7, 2024

TODO:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working integration:pinecone P3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants