Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update integration tests workflow to set global working-directory #363

Closed
silvanocerza opened this issue Feb 8, 2024 · 0 comments · Fixed by #429
Closed

Update integration tests workflow to set global working-directory #363

silvanocerza opened this issue Feb 8, 2024 · 0 comments · Fixed by #429
Assignees
@masci
Labels
contributions wanted! Looking for external contributions topic:CI

Comments

@silvanocerza
Copy link
Contributor

silvanocerza commented Feb 8, 2024 •
edited
Loading

As of now most integrations tests workflow have a global working-directory set to the integration folder.

We should standardize this to avoid confusing errors on those workflows that don't have it set.

This is missing only in the ollama and unstructured workflows.

Example workflow with default global working-directory.

haystack-core-integrations/.github/workflows/chroma.yml

Lines 13 to 15 in 5096aea

defaults:
run:
working-directory: integrations/chroma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masci masci

Labels
contributions wanted! Looking for external contributions topic:CI
Projects
Haystack - Contributions wanted
Archived in project
Milestone
No milestone
2 participants
@masci @silvanocerza