Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MistralChatAdapter: Typo in the max_tokens #741

Closed
vish9812 opened this issue May 21, 2024 · 0 comments
Closed

MistralChatAdapter: Typo in the max_tokens #741

vish9812 opened this issue May 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vish9812
Copy link
Contributor

MistralChatAdapter's ALLOWED_PARAMS has max_tokens but generation_kwargs is using max_gen_len. Because of this discrepancy, max_tokens limit is set to the default 512 whenever running the model.

  • Haystack version: 2.1.2
  • Integration version: 0.7.1

Related PR - #740
@vish9812 vish9812 added the bug Something isn't working label May 21, 2024
@vish9812 vish9812 mentioned this issue May 21, 2024
Merged
@masci masci closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@masci @vish9812