Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make truncation optional for AmazonBedrockGenerators #785

Closed
sjrl opened this issue Jun 5, 2024 · 0 comments · Fixed by #833
Closed

Make truncation optional for AmazonBedrockGenerators #785

sjrl opened this issue Jun 5, 2024 · 0 comments · Fixed by #833
Assignees
Labels
feature request Ideas to improve an integration integration:amazon-bedrock

Comments

@sjrl
Copy link
Contributor

sjrl commented Jun 5, 2024

Is your feature request related to a problem? Please describe.
We've found that in some situations we'd prefer the model provider (e.g. Bedrock) to return with an error message if the prompt is too long rather than truncate the end of the prompt which can lead to non-sensical answers depending on how the prompt template is constructed. So I propose adding a parameter to toggle this behavior with the default behavior being unchanged (i.e. truncation=True is the same as the previous default behavior).

Describe the solution you'd like
Similar solution as was implemented in this PR for Haystack v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas to improve an integration integration:amazon-bedrock
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants