Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflicting packages optimum-haystack and instructor-embedders-haystack #929

Closed
ArzelaAscoIi opened this issue Jul 30, 2024 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@ArzelaAscoIi
Copy link
Member

Describe the bug

These packages are incompatible

To Reproduce

  • just install both packages

Describe your environment (please complete the following information):

  • OS: [e.g. iOS]
  • Haystack version:
  • Integration version:
@ArzelaAscoIi ArzelaAscoIi added the bug Something isn't working label Jul 30, 2024
@ArzelaAscoIi ArzelaAscoIi changed the title https://github.com/deepset-ai/haystack-core-integrations/blob/b8e2623014be9ab7410d98832e25eda46923b04c/integrations/optimum/pyproject.toml#L36 Conflicting packages optimum-haystack and instructor-embedders-haystack Jul 30, 2024
@julian-risch
Copy link
Member

@ArzelaAscoIi After a first look at the dependencies my guess is that we can remove the <2.3.0 pin from the instructor-embedder integration because there is also no upper limit for the version set here https://github.com/xlang-ai/instructor-embedding/blob/main/requirements.txt#L9

@anakin87
Copy link
Member

I'm not sure... I pinned the dependency because Instructor Embeddings were not working with sentence_transformers>=2.3.0. #289

Then they updated the main branch (xlang-ai/instructor-embedding#112), but a new package was not released. https://pypi.org/project/InstructorEmbedding/#history; xlang-ai/instructor-embedding#112 (comment).

So, we should try...

@anakin87
Copy link
Member

I tried to unpin the dependency and using sentence-transformers==3.0.1 (latest),
I get these errors when running the tests:

FAILED tests/test_instructor_document_embedder.py::TestInstructorDocumentEmbedder::test_run - TypeError: INSTRUCTOR._load_sbert_model() got an unexpected keyword argument 'token'
FAILED tests/test_instructor_text_embedder.py::TestInstructorTextEmbedder::test_run - TypeError: INSTRUCTOR._load_sbert_model() got an unexpected keyword argument 'token'

@julian-risch
Copy link
Member

Thanks @anakin87 ! That means at the moment the two packages are not compatible and there is nothing we can do about it, which is why I suggest we close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants