Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make nightly tests actually run with Haystack main branch #1251

Merged
merged 3 commits into from
Dec 18, 2024
Merged

ci: make nightly tests actually run with Haystack main branch #1251

merged 3 commits into from
Dec 18, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Dec 18, 2024 •
edited
Loading

Related Issues

After the release of the new ChatMessage in deepset-ai/haystack#8640, I was expecting several failures in the nightly tests with Haystack main.

Indeed, I encountered these failures locally by executing the following steps:

...
 cd "$dir"
hatch env prune
hatch run uv pip install git+https://github.com/deepset-ai/haystack.git
hatch run uv pip freeze

However the nightly CI tests did not fail... 🤔

Then I realized what's the difference:

haystack-core-integrations/.github/workflows/amazon_bedrock.yml

Line 84 in 3a3419a

hatch run pip install git+https://github.com/deepset-ai/haystack.git

We are not using uv there, so the tests don't run with Haystack main, but with the latest stable release.

Proposed Changes:

  • use uv to install Haystack main in the test environment

How did you test it?

Local tests, CI

Notes for the reviewer

Failing tests are unrelated to this PR

Checklist

@anakin87 anakin87 marked this pull request as ready for review December 18, 2024 09:10
@anakin87 anakin87 requested a review from a team as a code owner December 18, 2024 09:10
@anakin87 anakin87 requested review from julian-risch and removed request for a team December 18, 2024 09:10
@anakin87 anakin87 changed the title ci: fix nightly runs with Haystack main ci: make nightly tests actually run with Haystack main branch Dec 18, 2024
@julian-risch
Copy link
Member

julian-risch commented Dec 18, 2024 •
edited
Loading

@anakin87 To explicitly install from main, we should use pip install git+https://github.com/deepset-ai/haystack.git@main with @main at the end. Using uv sounds good too. So I'd suggest changing all lines to hatch run uv pip install git+https://github.com/deepset-ai/haystack.git@main.

@anakin87
Copy link
Member Author

@julian-risch I incorporated your feedback.
Just to clarify about uv: using uv is important because our hatch environment uses it as an installer, so if we don't install Haystack main using it, the tests are not run using the main branch.

julian-risch
julian-risch approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@anakin87 anakin87 merged commit 7f62ca8 into main Dec 18, 2024
162 checks passed
@anakin87 anakin87 deleted the fix-nightly-runs-with-haystack-main branch December 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
integration:amazon-bedrock integration:amazon-sagemaker integration:astra integration:azure-ai-search integration:chroma integration:cohere integration:deepeval integration:elasticsearch integration:fastembed integration:google-ai integration:google-vertex integration:instructor-embedders integration:jina integration:langfuse integration:llama_cpp integration:mistral integration:mongodb-atlas integration:nvidia integration:ollama integration:opensearch integration:optimum integration:pgvector integration:pinecone integration:qdrant integration:ragas integration:snowflake integration:unstructured-fileconverter integration:weaviate topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @julian-risch