Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with weaviate_client 4.7.1 #247

Closed
kleag opened this issue Jul 30, 2024 · 1 comment
Closed

Incompatibility with weaviate_client 4.7.1 #247

kleag opened this issue Jul 30, 2024 · 1 comment

Comments

@kleag
Copy link

kleag commented Jul 30, 2024

Using default versions collected by pip I get:

generator-1        |   File "/usr/local/lib/python3.9/site-packages/haystack/core/pipeline/pipeline.py", line 249, in run
generator-1        |     res: Dict[str, Any] = self._run_component(name, last_inputs[name])
generator-1        |   File "/usr/local/lib/python3.9/site-packages/haystack/core/pipeline/pipeline.py", line 76, in _run_component
generator-1        |     res: Dict[str, Any] = instance.run(**inputs)
generator-1        |   File "/usr/local/lib/python3.9/site-packages/haystack_integrations/components/retrievers/weaviate/embedding_retriever.py", line 137, in run
generator-1        |     documents = self._document_store._embedding_retrieval(
generator-1        |   File "/usr/local/lib/python3.9/site-packages/haystack_integrations/document_stores/weaviate/document_store.py", line 525, in _embedding_retrieval
generator-1        |     properties = [p.name for p in self.collection.config.get().properties]
generator-1        |   File "/usr/local/lib/python3.9/site-packages/haystack_integrations/document_stores/weaviate/document_store.py", line 217, in collection
generator-1        |     client = self.client
generator-1        |   File "/usr/local/lib/python3.9/site-packages/haystack_integrations/document_stores/weaviate/document_store.py", line 206, in client
generator-1        |     self._client.collections._get_all(simple=True)
generator-1        | AttributeError: '_Collections' object has no attribute '_get_all'

And in fact, in weaviate_client 4.7.1, the _Collections class is no more a subclass of _CollectionsBase which implements the _get_all method.
making them incompatible.
Using _get_all in haystack_integration is maybe the problem as it is a protected method, but I don't know enough the code of both tools to judge.

@julian-risch
Copy link
Member

Hi @kleag , thanks for opening this issue. Happy to report that the issue was fixed with the latest release of the integration 2.2.0 on August 3. https://pypi.org/project/weaviate-haystack/2.2.0/ The release includes the following PR where we replaced _get_all with list_all: deepset-ai/haystack-core-integrations#921

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants