diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a867f2270a..5c43316ab4 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -342,7 +342,7 @@ jobs: - "url:https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" trigger-catch-all: - name: Trigger-catch-all-check + name: Tests completed # This job will be executed only after all the other tests # are successful. # This way we'll be able to mark only this test as required @@ -352,3 +352,5 @@ jobs: - integration-tests-macos - integration-tests-windows uses: deepset-ai/haystack/.github/workflows/tests_skipper_workflow.yml@ci/fix-catch-all2 + with: + tests_were_skipped: false diff --git a/.github/workflows/tests_skipper_trigger.yml b/.github/workflows/tests_skipper_trigger.yml index 86bb64f6bb..6b4dba4a64 100644 --- a/.github/workflows/tests_skipper_trigger.yml +++ b/.github/workflows/tests_skipper_trigger.yml @@ -40,8 +40,10 @@ jobs: - test/test_requirements.txt trigger-catch-all: - name: Trigger-catch-all-check + name: Tests completed # Don't run this check if the PR contains both code and non-code changes (e.g. release notes) needs: check_if_changed if: needs.check_if_changed.outputs.code_changes == 'false' uses: deepset-ai/haystack/.github/workflows/tests_skipper_workflow.yml@ci/fix-catch-all2 + with: + tests_were_skipped: true diff --git a/.github/workflows/tests_skipper_workflow.yml b/.github/workflows/tests_skipper_workflow.yml index 8d35988919..8a812b944e 100644 --- a/.github/workflows/tests_skipper_workflow.yml +++ b/.github/workflows/tests_skipper_workflow.yml @@ -5,6 +5,10 @@ name: Tests on: workflow_call: + inputs: + tests_were_skipped: + type: boolean + required: true jobs: catch-all: @@ -13,4 +17,8 @@ jobs: runs-on: ubuntu-latest steps: - name: Skip tests + if: ${{ github.event.inputs.tests_were_skipped }} run: echo "Skipped!" + - name: Tests completed successfully + if: ${{ !github.event.inputs.tests_were_skipped }} + run: echo "Tests completed!"