Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Whisper transcriber (v2.0) to OpenAI SDK #5731

Closed
ZanSara opened this issue Sep 6, 2023 · 7 comments · Fixed by #6149
Closed

Migrate Whisper transcriber (v2.0) to OpenAI SDK #5731

ZanSara opened this issue Sep 6, 2023 · 7 comments · Fixed by #6149
Labels
2.x Related to Haystack v2.0 good first issue Good for newcomers

Comments

@ZanSara
Copy link
Contributor

ZanSara commented Sep 6, 2023

Now that we're using OpenAI's SDK for LLM generators, we should also migrate Whisper transcriber to OpenAI SDK instead of using whisper-openai, to reduce the number of dependencies.

@ZanSara ZanSara added the 2.x Related to Haystack v2.0 label Sep 6, 2023
@masci masci added the good first issue Good for newcomers label Sep 13, 2023
@ShatilKhan
Copy link

I'd like to work on this & please provide additional info about this issue on how to achieve the goal

@Mohit1345
Copy link

@ZanSara I have checked over repo, there are three whisper based classes
1.WhisperTranscriber
2.RemoteWhisperTranscriber
3.LocalWhisperTranscriber
In this the RemoteWhisperTranscriber is running with api and LocalWhisperTranscriber is working with whisper-openai.
So, overall what changes we have to make.

@chandakya343
Copy link

Please assign me this issue! I am a beginner and I would like to fix a good-first-issue

@anakin87
Copy link
Member

Hello everybody!

This is the related class: RemoteWhisperTranscriber.

You can consider this as an example of managing the OpenAI SDK: OpenAITextEmbedder

Feel free to work on this and submit a PR...

@awinml
Copy link
Contributor

awinml commented Oct 22, 2023

I would like to work on this issue. I have opened a PR #6149.

The PR also fixes a part of #6116 and removes the api_key from serialization of RemoteWhisperTranscriber.

@anakin87
Copy link
Member

Hello, @Mohit1345 and @awinml and thanks for your efforts...

It would be great if you could work together to realize this migration.

I suggest you collaborate on #6149 (because it also fixes part of #6116).

@Mohit1345
Copy link

Hello, @Mohit1345 and @awinml and thanks for your efforts...

It would be great if you could work together to realize this migration.

I suggest you collaborate on #6149 (because it also fixes part of #6116).

How can we move forward , I have replaced the whisper-openai to open ai sdk based transcription code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 good first issue Good for newcomers
Projects
None yet
8 participants