Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticSearchBM25Retriever doesn't accept top_k in the run function #6600

Closed
TuanaCelik opened this issue Dec 19, 2023 · 2 comments
Closed

ElasticSearchBM25Retriever doesn't accept top_k in the run function #6600

TuanaCelik opened this issue Dec 19, 2023 · 2 comments
Labels
2.x Related to Haystack v2.0 topic:elasticsearch topic:retriever

Comments

@TuanaCelik
Copy link
Contributor

The top_k can only be defined at initialization. It would be great if users got the option to change the top_k at pipeline runtime too.
@sahusiddharth
Copy link
Contributor

@TuanaCelik I have made the changes in the haystack-core-integrations, can you please have a look and let me know if I'm in the right direction or not.

Here is the link

@anakin87
Copy link
Member

fixed in deepset-ai/haystack-core-integrations#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Related to Haystack v2.0 topic:elasticsearch topic:retriever
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TuanaCelik @anakin87 @sahusiddharth