Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Azure openAI models (Embedder and Generator) #6620

Closed
trungtly opened this issue Dec 22, 2023 · 2 comments
Closed

Support Azure openAI models (Embedder and Generator) #6620

trungtly opened this issue Dec 22, 2023 · 2 comments

Comments

@trungtly
Copy link

trungtly commented Dec 22, 2023

Is your feature request related to a problem? Please describe.
Please add support for Azure openAI models for Embedder and Generator

Describe the solution you'd like
api_base, api_version needs to be added

https://learn.microsoft.com/en-us/azure/ai-services/openai/quickstart?tabs=command-line%2Cpython-new&pivots=programming-language-python

Haystack v1 has already has this feature implemented, eg:
https://github.com/deepset-ai/haystack/blob/v1.23.x/haystack/nodes/prompt/invocation_layer/azure_open_ai.py

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@mathislucka
Copy link
Member

Thanks for bringing this up. We'll work on that in the coming weeks. Tracking progress separately in the two issues above.

@vblagoje
Copy link
Member

vblagoje commented Jan 7, 2024

Closing this issue as completed. We have implemented and added both Azure embedders and generators

@vblagoje vblagoje closed this as completed Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants