Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port selected 1.x components to 2.x #6673

Closed
6 of 7 tasks
julian-risch opened this issue Jan 2, 2024 · 4 comments
Closed
6 of 7 tasks

Port selected 1.x components to 2.x #6673

julian-risch opened this issue Jan 2, 2024 · 4 comments
Labels
2.x Related to Haystack v2.0 epic

Comments

@julian-risch
Copy link
Member

julian-risch commented Jan 2, 2024

We identified the following key components from Haystack 1.x that still need to be ported to Haystack 2.0:

Tasks

Preview Give feedback
  1. 6 of 6
  2. sjrl
  3. sjrl
  4. 2.x P2
    shadeMe
  5. 2.x type:feature
@julian-risch julian-risch added epic 2.x Related to Haystack v2.0 labels Jan 2, 2024
@julian-risch julian-risch changed the title Port the implementation of 1.x components to 2.x Port selected 1.x components to 2.x Jan 2, 2024
@sjrl
Copy link
Contributor

sjrl commented Jan 2, 2024

Hey @julian-risch could we also add the nltk support for the DocumentSplitter in this list? That is a very common feature we are using right now in Haystack v1.

@sjrl
Copy link
Contributor

sjrl commented Jan 2, 2024

And to clarify, is the TextClassifier in this list referring to the TransformersQueryClassifier from Haystack v1?

@julian-risch
Copy link
Member Author

@sjrl Yes, it's about porting TransformersQueryClassifier but could become two classes TransformersTextClassifier and TransformersDocumentClassifier. That would be consistent with the SentenceTransformersDocumentEmbedder and the SentenceTransformersTextEmbedder we have in 2.x. Should behave similar to https://github.com/deepset-ai/haystack/blob/main/haystack/components/classifiers/document_language_classifier.py

@sjrl
Copy link
Contributor

sjrl commented Feb 5, 2024

@julian-risch thanks for the clarification! @bglearning might also be taking a look at porting the TransformersQueryClassifier, so tagging him here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 epic
Projects
Development

No branches or pull requests

3 participants