Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use of legacy filters syntax in InMemoryDocumentStore #7893

Closed
silvanocerza opened this issue Jun 19, 2024 · 2 comments
Closed

Deprecate use of legacy filters syntax in InMemoryDocumentStore #7893

silvanocerza opened this issue Jun 19, 2024 · 2 comments
Assignees
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint topic:DX Developer Experience type:documentation Improvements on the docs

Comments

@silvanocerza
Copy link
Contributor

The legacy filters syntax from Haystack 1 must be deprecated in favour of the new one.

As of now if the legacy syntax is used we automatically convert it internally to the new one.
We should emit a deprecation warning instead.

After that is done we can also remove some utility classes in testing used to test Document Stores.

@silvanocerza silvanocerza transferred this issue from deepset-ai/haystack-core-integrations Jun 19, 2024
@shadeMe shadeMe added 2.x Related to Haystack v2.0 type:documentation Improvements on the docs topic:DX Developer Experience labels Jun 25, 2024
@mrm1001 mrm1001 added the P1 High priority, add to the next sprint label Jul 5, 2024
@vblagoje
Copy link
Member

vblagoje commented Jul 8, 2024

@silvanocerza we also convert filters in MetadataRouter. To avoid tracking current and new usages of convert why don't we simply add deprecation warning to convert:

warnings.warn(
        "You are using deprecated filter syntax. Please use the new filter syntax as described "
        "in the documentation. We will attempt to convert your old filter syntax to the new one. The old syntax "
        "support will be removed in Haystack 2.5",
        DeprecationWarning,
    )

And then simply remove the relevant code handing convert invocation altogether.

@vblagoje
Copy link
Member

Resolved with #8004

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to Haystack v2.0 P1 High priority, add to the next sprint topic:DX Developer Experience type:documentation Improvements on the docs
Projects
None yet
Development

No branches or pull requests

4 participants