Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for secret management and from_env_var for OpenSearch integration #8659

Open
aantti opened this issue Dec 18, 2024 · 0 comments
Open
Labels
P2 Medium priority, add to the next sprint if no P1 available

Comments

@aantti
Copy link
Contributor

aantti commented Dec 18, 2024

When using OpenSearch as document store it's not currently possible to utilize secret management and easily pick credentials for HTTP basic auth from environment.

It can definitely be instrumented along the lines of:

    return OpenSearchDocumentStore(
        hosts=settings.opensearch_host,
        http_auth=(settings.opensearch_user, settings.opensearch_password),

while managing settings separately.

However, there's also a somewhat bigger problem when trying to use YAML to override pipeline architecture (or just load pipeline definitions from YAML), because it would currently look like:

  document_writer:
    init_parameters:
      document_store:
        init_parameters:
          create_index: true
          embedding_dim: 768
          hosts: 
            - https://localhost:9200
          http_auth:
            - admin
            - your-password

which isn't ideal for any serious deployment scenarios.

If would be great to have an option to use secret management and consequently env_vars supported for YAML for OpenSearch.

@julian-risch julian-risch added the P2 Medium priority, add to the next sprint if no P1 available label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority, add to the next sprint if no P1 available
Projects
None yet
Development

No branches or pull requests

2 participants