Skip to content
This repository was archived by the owner on Feb 15, 2025. It is now read-only.

Context Cancellation #139

Closed
Tracked by #320
gerred opened this issue Jul 10, 2023 · 4 comments
Closed
Tracked by #320

Context Cancellation #139

gerred opened this issue Jul 10, 2023 · 4 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gerred
Copy link
Contributor

gerred commented Jul 10, 2023

cc @DayOfThePenguin

One issue right now is even if gRPC gets cancelled, backend models will continue generating into the void. This can cause model servers to seemingly hang while the thread is blocked.

We need some sort of async cancellation mechanism to stop a generation.

@gerred gerred added this to the Q3 milestone Jul 10, 2023
@gerred gerred added good first issue Good for newcomers help wanted Extra attention is needed possible-bug 🐛 Something may not be working bug Something isn't working enhancement New feature or request and removed possible-bug 🐛 Something may not be working labels Jul 10, 2023
@edengebrezgi edengebrezgi self-assigned this Dec 14, 2023
@vanakema
Copy link
Contributor

@edengebrezgi did you happen to start this ticket yet? If not, would you mind if I took over?

@justinthelaw
Copy link
Contributor

@vanakema no body has started on this one yet! You can work on it if you'd like. Let me know if you have questions or want to pair on it!

@vanakema
Copy link
Contributor

@justinthelaw would love to pair on it! How should we coordinate?

@justinthelaw
Copy link
Contributor

Closed in favor of: #277 #279 #280

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants