Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master branch tests failing PRs #149

Open
crypto-b opened this issue Feb 11, 2021 · 0 comments
Open

Master branch tests failing PRs #149

crypto-b opened this issue Feb 11, 2021 · 0 comments

Comments

@crypto-b
Copy link

Hi,

One of the tokens in the master branch is causing all PRs to fail. Here is the snippet from the build logs (build 10.X):

FAIL test/token-metadata/metadata.test.js (54.782 s)
  ● metadata.json › 0x967da4048cD07aB37855c090aAF366e4ce1b9F48 › metadata.json › should only have valid fields

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      80 |                             it("should only have valid fields", () => {
      81 |                                 const fields = metadata.socialLinks.map(({ type }) => type);
    > 82 |                                 expect(fields.every(field => VALID_SOCIAL_LINK_FIELDS.includes(field.toLowerCase()))).toBe(true);
         |                                                                                                                       ^
      83 |                             })
      84 | 
      85 |                             if (metadata.twitter) {

      at Object.it (test/token-metadata/metadata.test.js:82:119)

OCEAN has a github type social link which isn't supported in the tests.

https://github.com/defi-wikis/defi-tokens-wiki/blob/master/token-metadata/0x967da4048cD07aB37855c090aAF366e4ce1b9F48/metadata.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant