Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle errors during sync #38

Merged
merged 1 commit into from
Sep 12, 2024
Merged

feat: handle errors during sync #38

merged 1 commit into from
Sep 12, 2024

Conversation

0xyaco
Copy link
Collaborator

@0xyaco 0xyaco commented Sep 10, 2024

🤖 Linear

Closes GRT-139

Description

TL;DR fetching events failures won't make the whole agent crash now. 🥅

  • Handle errors during sync by catching and logging them making the sync more robust.
  • Added more verbose logging inside the sync method to improve its traceability.

@linear Linear
Copy link

linear bot commented Sep 10, 2024

GRT-139 No error handling while getting events

0xnigir1
0xnigir1 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@0xnigir1 0xnigir1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@0xyaco 0xyaco merged commit 4186fff into dev Sep 12, 2024
5 checks passed
@0xyaco 0xyaco deleted the feat/handle-sync-errors branch September 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnigir1 0xnigir1 0xnigir1 approved these changes

@0xkenj1 0xkenj1 0xkenj1 approved these changes

@jahabeebs jahabeebs jahabeebs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xyaco @jahabeebs @0xkenj1 @0xnigir1