Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: approved modules types #73

Merged
merged 6 commits into from
Oct 28, 2024
Merged

fix: approved modules types #73

merged 6 commits into from
Oct 28, 2024

Conversation

0xyaco
Copy link
Collaborator

@0xyaco 0xyaco commented Oct 25, 2024

🤖 Linear

Closes GRT-233

Description

  • Removed RequestModule from modules that need approval
  • Refined wallet client type
  • getApprovedModules defaults to current L2 write client's address

Copy link

linear bot commented Oct 25, 2024

@0xyaco 0xyaco force-pushed the fix/approved-modules branch from bd80af1 to 05d9b28 Compare October 25, 2024 17:57
0xnigir1
0xnigir1 previously approved these changes Oct 25, 2024
jahabeebs
jahabeebs previously approved these changes Oct 25, 2024
@0xyaco 0xyaco dismissed stale reviews from jahabeebs and 0xnigir1 via b451286 October 28, 2024 09:14
@0xyaco 0xyaco merged commit d65f07b into dev Oct 28, 2024
5 checks passed
@0xyaco 0xyaco deleted the fix/approved-modules branch October 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants