Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chain table #12

Merged
merged 9 commits into from
Aug 2, 2024
Merged

feat: chain table #12

merged 9 commits into from
Aug 2, 2024

Conversation

0xtiti
Copy link
Collaborator

@0xtiti 0xtiti commented Aug 1, 2024

No description provided.

Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
z-kchain-hub-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 8:20pm

@0xtiti 0xtiti marked this pull request as ready for review August 2, 2024 20:03
Comment on lines 47 to 60
<STableRow key={index} onClick={() => handleChainNavigation(data.chainId)}>
<LogoCell sx={{ width: '60%' }}>
<ChainAvatar alt={`${data.chainName} logo`} src={data.iconUrl} />
<Typography>{data.chainName}</Typography>
{!data.rpc && <InfoTag information={t('HOME.DASHBOARD.noRPC')} />}
{!data.metadata && <InfoTag information={t('HOME.DASHBOARD.noMetadata')} />}
</LogoCell>
<STableCell sx={{ width: '10%' }}>{data.chainId}</STableCell>
<LogoCell sx={{ width: '10%' }}>
<TokenAvatar alt={`${data.nativeToken} logo`} src={data.tokenImgUrl} />
<Typography>{data.nativeToken}</Typography>
</LogoCell>
<STableCell sx={{ width: '10%' }}>{formatDataNumber(data.tvl, 0, true)}</STableCell>
<STableCell sx={{ width: '10%' }}>{data.chainType}</STableCell>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to identify the different sections and more vertical spacing would be great

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xtiti 0xtiti merged commit 8caa5ff into dev Aug 2, 2024
6 checks passed
@0xtiti 0xtiti deleted the feat/chain-table branch August 2, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants