From 2eec4450324cfd8457474d9de9cc1fd59579dc0f Mon Sep 17 00:00:00 2001 From: teddy Date: Thu, 18 Jul 2024 12:29:20 -0300 Subject: [PATCH] fix: feedback from review --- test/unit/BPool/BPool.t.sol | 7 ++++++- test/unit/BPool/BPool.tree | 4 +++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/test/unit/BPool/BPool.t.sol b/test/unit/BPool/BPool.t.sol index aec68fe7..f9583324 100644 --- a/test/unit/BPool/BPool.t.sol +++ b/test/unit/BPool/BPool.t.sol @@ -84,9 +84,14 @@ contract BPool is BPoolBase { // it calls _afterFinalize hook bPool.expectCall__afterFinalize(); - // it mints initial pool supply to controller + // it mints initial pool shares bPool.expectCall__mintPoolShare(INIT_POOL_SUPPLY); + // it sends initial pool shares to controller bPool.expectCall__pushPoolShare(address(this), INIT_POOL_SUPPLY); + // it emits a LOG_CALL event + bytes memory data = abi.encodeCall(IBPool.finalize, ()); + vm.expectEmit(address(bPool)); + emit IBPool.LOG_CALL(IBPool.finalize.selector, address(this), data); bPool.finalize(); // it finalizes the pool diff --git a/test/unit/BPool/BPool.tree b/test/unit/BPool/BPool.tree index bbe1d56d..1f8f368e 100644 --- a/test/unit/BPool/BPool.tree +++ b/test/unit/BPool/BPool.tree @@ -29,6 +29,8 @@ BPool::finalize ├── when there are too few tokens bound │ └── it should revert └── when preconditions are met + ├── it emits LOG_CALL event ├── it finalizes the pool - ├── it mints initial pool supply to controller + ├── it mints initial pool shares + ├── it sends initial pool shares to controller └── it calls _afterFinalize hook