fix: addressing comments in PR

defi-wonderland · Jul 25, 2024 · f197a54 · f197a54
1 parent ccdd8de
commit f197a54
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -60,14 +60,14 @@ yarn test    # run the tests
 
 # Deployments
 Ethereum Mainnet:
-  - BCoWFactory: (0x5AC134DAC7070eFeE8b1C5e3fD0B353922ceD843)[https://etherscan.io/address/0x5AC134DAC7070eFeE8b1C5e3fD0B353922ceD843]
-  - BCoWHelper: (0x703Bd8115E6F21a37BB5Df97f78614ca72Ad7624)[https://etherscan.io/address/0x703Bd8115E6F21a37BB5Df97f78614ca72Ad7624]
+  - BCoWFactory: [0x5AC134DAC7070eFeE8b1C5e3fD0B353922ceD843](https://etherscan.io/address/0x5AC134DAC7070eFeE8b1C5e3fD0B353922ceD843)
+  - BCoWHelper: [0x703Bd8115E6F21a37BB5Df97f78614ca72Ad7624](https://etherscan.io/address/0x703Bd8115E6F21a37BB5Df97f78614ca72Ad7624)
 
 Ethereum Sepolia:
-  - BCoWFactory: (0xf3916A8567DdC51a60208B35AC542F5226f46773)[https://sepolia.etherscan.io/address/0xf3916A8567DdC51a60208B35AC542F5226f46773]
-  - BCoWHelper: (0x55DDf396886C85e443E0B5A8E42CAA3939E4Cf50)[https://sepolia.etherscan.io/address/0x55DDf396886C85e443E0B5A8E42CAA3939E4Cf50]
-  - BCoWPool: (0x60048091401F27117C3DFb8136c1ec550D949B12)[https://sepolia.etherscan.io/address/0x60048091401F27117C3DFb8136c1ec550D949B12]
+  - BCoWFactory: [0xf3916A8567DdC51a60208B35AC542F5226f46773](https://sepolia.etherscan.io/address/0xf3916A8567DdC51a60208B35AC542F5226f46773)
+  - BCoWHelper: [0x55DDf396886C85e443E0B5A8E42CAA3939E4Cf50](https://sepolia.etherscan.io/address/0x55DDf396886C85e443E0B5A8E42CAA3939E4Cf50)
+  - BCoWPool: [0x60048091401F27117C3DFb8136c1ec550D949B12](https://sepolia.etherscan.io/address/0x60048091401F27117C3DFb8136c1ec550D949B12)
 
   Gnosis Mainnet:
-  - BCoWFactory: (0xaD0447be7BDC80cf2e6DA20B13599E5dc859b667)[https://etherscan.io/address/0xaD0447be7BDC80cf2e6DA20B13599E5dc859b667]
-  - BCoWHelper: (0x21Ac2E4115429EcE4b5FE79409fCC48EB6315Ccc)[https://gnosisscan.io/address/0x21Ac2E4115429EcE4b5FE79409fCC48EB6315Ccc]
+  - BCoWFactory: [0xaD0447be7BDC80cf2e6DA20B13599E5dc859b667](https://gnosisscan.io/address/0xaD0447be7BDC80cf2e6DA20B13599E5dc859b667)
+  - BCoWHelper: [0x21Ac2E4115429EcE4b5FE79409fCC48EB6315Ccc](https://gnosisscan.io/address/0x21Ac2E4115429EcE4b5FE79409fCC48EB6315Ccc)
diff --git a/package.json b/package.json
@@ -19,7 +19,7 @@
     "deploy:bcowfactory:gnosis": "forge script DeployBCoWFactory -vvvvv --rpc-url $GNOSIS --broadcast --chain gnosis --private-key $GNOSIS_DEPLOYER_PK --verify",
     "deploy:bcowfactory:mainnet": "forge script DeployBCoWFactory -vvvvv --rpc-url $MAINNET_RPC --broadcast --chain mainnet --private-key $MAINNET_DEPLOYER_PK --verify",
     "deploy:bcowfactory:testnet": "forge script DeployBCoWFactory -vvvvv --rpc-url $SEPOLIA_RPC --broadcast --chain sepolia --private-key $SEPOLIA_DEPLOYER_PK --verify",
-    "deploy:bfactory:gnosis": "forge script DeployBFactory -vvvvv --rpc-url $GNOSIS --broadcast --chain gnosis --private-key $GNOSIS_DEPLOYER_PK --verify",
+    "deploy:bfactory:gnosis": "forge script DeployBFactory -vvvvv --rpc-url $GNOSIS_RPC --broadcast --chain gnosis --private-key $GNOSIS_DEPLOYER_PK --verify",
     "deploy:bfactory:mainnet": "forge script DeployBFactory -vvvvv --rpc-url $MAINNET_RPC --broadcast --chain mainnet --private-key $MAINNET_DEPLOYER_PK --verify",
     "deploy:bfactory:testnet": "forge script DeployBFactory -vvvvv --rpc-url $SEPOLIA_RPC --broadcast --chain sepolia --private-key $SEPOLIA_DEPLOYER_PK --verify",
     "lint:bulloak": "find test/unit -name '*.tree' | xargs bulloak check",

diff --git a/script/Registry.s.sol b/script/Registry.s.sol
@@ -14,7 +14,6 @@ abstract contract Registry is Params {
   BCoWHelper public bCoWHelper;
 
   constructor(uint256 chainId) Params(chainId) {
-    // TODO: redeploy
     if (chainId == 1) {
       // Ethereum Mainnet
       bCoWFactory = BCoWFactory(0x5AC134DAC7070eFeE8b1C5e3fD0B353922ceD843);
@@ -28,7 +27,6 @@ abstract contract Registry is Params {
       bCoWFactory = BCoWFactory(0xf3916A8567DdC51a60208B35AC542F5226f46773);
       bCoWHelper = BCoWHelper(0x55DDf396886C85e443E0B5A8E42CAA3939E4Cf50);
     } else {
-      // TODO: add Gnosis chain
       revert('Registry: unknown chain ID');
     }
   }