From 41cd0886cdfa8b977847010b1c79558f4989f2ec Mon Sep 17 00:00:00 2001 From: 0xkenj1 Date: Wed, 23 Oct 2024 13:32:24 -0300 Subject: [PATCH] fix: pr comments --- apps/indexer/package.json | 2 +- apps/indexer/pnpm-lock.yaml | 42 +++++++++---------- .../registry/handlers/roleGranted.handler.ts | 6 +-- .../test/registry/registry.processor.spec.ts | 2 +- 4 files changed, 26 insertions(+), 26 deletions(-) diff --git a/apps/indexer/package.json b/apps/indexer/package.json index 180a03c..c47c442 100644 --- a/apps/indexer/package.json +++ b/apps/indexer/package.json @@ -13,7 +13,7 @@ }, "dependencies": { "chai": "4.3.10", - "envio": "2.4.1", + "envio": "2.5.2", "ethers": "6.8.0", "yaml": "2.5.1" }, diff --git a/apps/indexer/pnpm-lock.yaml b/apps/indexer/pnpm-lock.yaml index c60513e..f000935 100644 --- a/apps/indexer/pnpm-lock.yaml +++ b/apps/indexer/pnpm-lock.yaml @@ -11,8 +11,8 @@ importers: specifier: 4.3.10 version: 4.3.10 envio: - specifier: 2.4.1 - version: 2.4.1 + specifier: 2.5.2 + version: 2.5.2 ethers: specifier: 6.8.0 version: 6.8.0 @@ -895,42 +895,42 @@ packages: integrity: sha512-+uw1inIHVPQoaVuHzRyXd21icM+cnt4CzD5rW+NC1wjOUSTOs+Te7FOv7AhN7vS9x/oIyhLP5PR1H+phQAHu5Q==, } - envio-darwin-arm64@2.4.1: + envio-darwin-arm64@2.5.2: resolution: { - integrity: sha512-uwwKhThFH9dZhQKd6kmleeTyl//GlJGvhFXuhuJ7xn93oGbOOy3hsoYfJZSbVmb0SSSJkgWdAKN82mYHNfdVwQ==, + integrity: sha512-O/+sgImwhQJXlaypMgESWRUzVlkA3dH+2JpdI1LcIVuCpRN/OvBUbRxDHOU79uxeGXvUeeCn1zSGukod6hxG7g==, } cpu: [arm64] os: [darwin] - envio-darwin-x64@2.4.1: + envio-darwin-x64@2.5.2: resolution: { - integrity: sha512-SKqI2hQmjmqlDYCwFaEK6TDJMLL/UE/wWlUIzsAY5drJQTwAL0mBXzUfQM8JbMgDoxeWyKNegUV1vCuTmCDREw==, + integrity: sha512-/K1XCoIXnjTG4LWUqUUPpSdIBFC1tsryQLp1c040YNnsqVmE9EJufclUL0dc2Rf8SNqC/XgNPGWlndcBDSJWFw==, } cpu: [x64] os: [darwin] - envio-linux-arm64@2.4.1: + envio-linux-arm64@2.5.2: resolution: { - integrity: sha512-ujUUifyKM4kHkHfcudeH8iIf5xPiW9t+IzMCgY4gug2fs3Z3biyhmeaylYNpvNiIoQ58vZqJ23fBKaUn7CPPog==, + integrity: sha512-OqrxwwdfN0mcipnq8TQYQL9yZHoHgr7QB8tILjkjtRhz9LOhyjjqlwmNKiDjbpQ8nR2odORKvTlJGEvHb2AO5A==, } cpu: [arm64] os: [linux] - envio-linux-x64@2.4.1: + envio-linux-x64@2.5.2: resolution: { - integrity: sha512-aeVQ9I4zum6X+kBeJrFev/bTDePZRSlt6HytcnqJd7+iWagQggUejhcrSccp2eRSeQ95sGp+F+lQOFfWJHyEJQ==, + integrity: sha512-qpJDjNeY8b8o1v47ulQgu0RGiN8T3BTg2veCRQHeHgpBqh1f7otPEqX2apADo5K+wYlUsH9HXJfbf25SLEQBdw==, } cpu: [x64] os: [linux] - envio@2.4.1: + envio@2.5.2: resolution: { - integrity: sha512-GsHv4S/mAzr//XCyTHFBnfd1CZFlfaG+wcWJkpeguzhnttNSOMJXCR4UPG0PxV2cZYiA3eVrOSPn58fTzk2G5g==, + integrity: sha512-fWHmggBijehdtOkSErHgASUiEhPwDi4ouxOdgHsi0B/DkabgwTYwa8Z+pBhf324exHhGRhAVxZwBtoKI98MUGA==, } hasBin: true @@ -2956,24 +2956,24 @@ snapshots: dependencies: once: 1.4.0 - envio-darwin-arm64@2.4.1: + envio-darwin-arm64@2.5.2: optional: true - envio-darwin-x64@2.4.1: + envio-darwin-x64@2.5.2: optional: true - envio-linux-arm64@2.4.1: + envio-linux-arm64@2.5.2: optional: true - envio-linux-x64@2.4.1: + envio-linux-x64@2.5.2: optional: true - envio@2.4.1: + envio@2.5.2: optionalDependencies: - envio-darwin-arm64: 2.4.1 - envio-darwin-x64: 2.4.1 - envio-linux-arm64: 2.4.1 - envio-linux-x64: 2.4.1 + envio-darwin-arm64: 2.5.2 + envio-darwin-x64: 2.5.2 + envio-linux-arm64: 2.5.2 + envio-linux-x64: 2.5.2 es-define-property@1.0.0: dependencies: diff --git a/packages/processors/src/registry/handlers/roleGranted.handler.ts b/packages/processors/src/registry/handlers/roleGranted.handler.ts index 5c246c8..1e8c22e 100644 --- a/packages/processors/src/registry/handlers/roleGranted.handler.ts +++ b/packages/processors/src/registry/handlers/roleGranted.handler.ts @@ -17,7 +17,7 @@ export class RoleGrantedHandler implements IEventHandler<"Registry", "RoleGrante ) {} async handle(): Promise { const { projectRepository } = this.dependencies; - const role = this.event.params.role.toLocaleLowerCase(); + const role = this.event.params.role.toLowerCase(); if (role === ALLO_OWNER_ROLE) { return []; } @@ -26,8 +26,8 @@ export class RoleGrantedHandler implements IEventHandler<"Registry", "RoleGrante const project = await projectRepository.getProjectById(this.chainId, role); // The member role for an Allo V2 profile, is the profileId itself. - // If a project exists with that id, we create the member role - // If it doesn't exists we create a pending project role. This can happens + // If a project exist with that id, we create the member role + // If it doesn't exist we create a pending project role. This can happen // when a new project is created, since in Allo V2 the RoleGranted event for a member is // emitted before the ProfileCreated event. if (project) { diff --git a/packages/processors/test/registry/registry.processor.spec.ts b/packages/processors/test/registry/registry.processor.spec.ts index 06dc730..7a8c5cf 100644 --- a/packages/processors/test/registry/registry.processor.spec.ts +++ b/packages/processors/test/registry/registry.processor.spec.ts @@ -35,7 +35,7 @@ describe("RegistryProcessor", () => { vi.resetAllMocks(); }); - it("should throw UnsupportedEventException for unsupported events", async () => { + it("throws UnsupportedEventException for unsupported events", async () => { const event: ProtocolEvent<"Registry", RegistryEvent> = { eventName: "UnsupportedEvent", } as unknown as ProtocolEvent<"Registry", RegistryEvent>;