From 28f44e94ba9bfcbd314281c0ab6c0109975a9cb1 Mon Sep 17 00:00:00 2001 From: zorzal Date: Thu, 31 Oct 2024 11:43:12 -0400 Subject: [PATCH] chore: lint --- solidity/test/integration/RequestCreation.t.sol | 1 - .../test/unit/modules/dispute/BondEscalationModule.t.sol | 6 ++++-- .../test/unit/modules/resolution/ArbitratorModule.t.sol | 8 ++------ 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/solidity/test/integration/RequestCreation.t.sol b/solidity/test/integration/RequestCreation.t.sol index 2fb7d77..629b00b 100644 --- a/solidity/test/integration/RequestCreation.t.sol +++ b/solidity/test/integration/RequestCreation.t.sol @@ -186,7 +186,6 @@ contract Integration_RequestCreation is IntegrationBase { vm.startPrank(requester); - // review: should we specify the evm error? // Check: reverts with `EVM error`? vm.expectRevert(); oracle.createRequest(mockRequest, _ipfsHash, _createAccessControl()); diff --git a/solidity/test/unit/modules/dispute/BondEscalationModule.t.sol b/solidity/test/unit/modules/dispute/BondEscalationModule.t.sol index 62a3b6a..e9a07c2 100644 --- a/solidity/test/unit/modules/dispute/BondEscalationModule.t.sol +++ b/solidity/test/unit/modules/dispute/BondEscalationModule.t.sol @@ -19,13 +19,15 @@ import { BondEscalationModule, IBondEscalationModule } from '../../../../contracts/modules/dispute/BondEscalationModule.sol'; -import '../../../../contracts/utils/Typehash.sol'; +import { + _PLEDGE_AGAINST_DISPUTE_TYPEHASH, _PLEDGE_FOR_DISPUTE_TYPEHASH +} from '../../../../contracts/utils/Typehash.sol'; import {IAccountingExtension} from '../../../../interfaces/extensions/IAccountingExtension.sol'; import {IBondEscalationAccounting} from '../../../../interfaces/extensions/IBondEscalationAccounting.sol'; + /** * @dev Harness to set an entry in the requestData mapping, without triggering setup request hooks */ - contract ForTest_BondEscalationModule is BondEscalationModule { constructor(IOracle _oracle) BondEscalationModule(_oracle) {} diff --git a/solidity/test/unit/modules/resolution/ArbitratorModule.t.sol b/solidity/test/unit/modules/resolution/ArbitratorModule.t.sol index 478b362..b385bc6 100644 --- a/solidity/test/unit/modules/resolution/ArbitratorModule.t.sol +++ b/solidity/test/unit/modules/resolution/ArbitratorModule.t.sol @@ -118,9 +118,7 @@ contract ArbitratorModule_Unit_StartResolution is BaseTest { _mockAndExpect( _arbitrator, abi.encodeCall( - arbitrator.resolve, - // review - (mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule))) + arbitrator.resolve, (mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule))) ), abi.encode(bytes('')) ); @@ -143,9 +141,7 @@ contract ArbitratorModule_Unit_StartResolution is BaseTest { _mockAndExpect( _arbitrator, abi.encodeCall( - arbitrator.resolve, - // review - (mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule))) + arbitrator.resolve, (mockRequest, mockResponse, mockDispute, _createAccessControl(address(arbitratorModule))) ), abi.encode(bytes('')) );