From 2b4f30951e8b824f62c4cc0ba60edbfb11155f4a Mon Sep 17 00:00:00 2001 From: zorzal Date: Wed, 27 Nov 2024 10:32:33 -0500 Subject: [PATCH] chore: remove commented code --- solidity/test/integration/AccountingExtension.t.sol | 5 ----- solidity/test/integration/Finalization.t.sol | 1 - solidity/test/integration/ResponseProposal.t.sol | 4 ---- 3 files changed, 10 deletions(-) diff --git a/solidity/test/integration/AccountingExtension.t.sol b/solidity/test/integration/AccountingExtension.t.sol index a56656d..beed357 100644 --- a/solidity/test/integration/AccountingExtension.t.sol +++ b/solidity/test/integration/AccountingExtension.t.sol @@ -21,7 +21,6 @@ contract Integration_AccountingExtension is IntegrationBase { * @notice Depositing ERC20 should update the virtual balance and the token contract balance */ function test_depositERC20() public { - // uint256 _initialBalance = 1 ether; uint256 _depositAmount = 1 ether; vm.assume(_initialBalance >= _depositAmount); @@ -57,7 +56,6 @@ contract Integration_AccountingExtension is IntegrationBase { * @notice Withdrawing ERC20 should update the virtual balance and the token contract balance */ function test_withdrawERC20() public { - // uint256 _initialBalance = 1 ether; uint256 _depositAmount = 1 ether; uint256 _withdrawAmount = 0.5 ether; @@ -78,7 +76,6 @@ contract Integration_AccountingExtension is IntegrationBase { * @notice Withdrawing more than the user's virtual balance should revert */ function test_withdrawERC20_insufficientFunds() public { - // uint256 _initialBalance = 1 ether; uint256 _depositAmount = 1 ether; uint256 _withdrawAmount = 2 ether; vm.assume(_withdrawAmount > _depositAmount); @@ -94,7 +91,6 @@ contract Integration_AccountingExtension is IntegrationBase { * @notice Withdrawing more WETH than was deposited by the user should revert */ function test_withdrawETH_insufficientFunds() public { - // uint256 _initialBalance = 1 ether; uint256 _depositAmount = 1 ether; uint256 _withdrawAmount = 2 ether; vm.assume(_withdrawAmount > _depositAmount); @@ -110,7 +106,6 @@ contract Integration_AccountingExtension is IntegrationBase { * @notice Withdrawing the bonded funds should revert */ function test_withdrawBondedFunds() public { - // uint256 _initialBalance = 1 ether; uint256 _bondAmount = 1 ether; vm.assume(_bondAmount > 0); _deposit(_accountingExtension, user, usdc, _bondAmount, _initialBalance); diff --git a/solidity/test/integration/Finalization.t.sol b/solidity/test/integration/Finalization.t.sol index a096acf..6fd1ea8 100644 --- a/solidity/test/integration/Finalization.t.sol +++ b/solidity/test/integration/Finalization.t.sol @@ -76,7 +76,6 @@ contract Integration_Finalization is IntegrationBase { */ function test_revertFinalizeInDisputeWindow() public { uint256 _timestamp = block.timestamp + _expectedDeadline - _baseDisputeWindow - 1; - // _timestamp = bound(_timestamp, block.timestamp, block.timestamp + _expectedDeadline - _baseDisputeWindow - 1); _createRequest(); _proposeResponse(); diff --git a/solidity/test/integration/ResponseProposal.t.sol b/solidity/test/integration/ResponseProposal.t.sol index a68c384..b70c251 100644 --- a/solidity/test/integration/ResponseProposal.t.sol +++ b/solidity/test/integration/ResponseProposal.t.sol @@ -52,8 +52,6 @@ contract Integration_ResponseProposal is IntegrationBase { uint256 _secondsAfter = 365 days; bytes memory _responseBytes = abi.encode('any-response'); - // _secondsAfter = bound(_secondsAfter, 1, type(uint248).max); - // Warp to timestamp after deadline vm.warp(block.timestamp + _expectedDeadline + _secondsAfter); @@ -78,8 +76,6 @@ contract Integration_ResponseProposal is IntegrationBase { vm.prank(proposer); oracle.proposeResponse(mockRequest, mockResponse, _createAccessControl()); - // review: When this request is _answered_? - mockResponse.response = abi.encode('second response'); // Check: does revert if already responded?