test: replace DSTestFull with Test #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gas1cent
reviewed
Nov 29, 2023
solidity/test/unit/Greeter.t.sol
Outdated
| @@ -74,7 +76,7 @@ contract UnitGreeterSetGreeting is Base { | |||
| function test_EmitEvent(string memory _greeting) public { | |||
| vm.assume(keccak256(bytes(_greeting)) != _emptyString); | |||
|
|
|||
| _expectEmitNoIndex(); | |||
| vm.expectEmit(false, false, false, true); | |||
There was a problem hiding this comment.
Doesn't hurt to always check the indexed parameters and the source of the event.
Suggested change
| vm.expectEmit(false, false, false, true); | |
| vm.expectEmit(true, true, true, true, address(_greeter)); |
gas1cent
previously approved these changes
Nov 29, 2023
0xng
reviewed
Nov 29, 2023
package.json
Outdated
| @@ -33,9 +33,8 @@ | |||
| }, | |||
| "dependencies": { | |||
| "ds-test": "github:dapphub/ds-test#e282159", | |||
There was a problem hiding this comment.
we cannot, because forge-std/Test.sol depends on this one
| @@ -1,5 +1,4 @@ | |||
| ds-test/=node_modules/ds-test/src | |||
There was a problem hiding this comment.
I tried, it doesn't work
There was a problem hiding this comment.
but why?
because of the import in Test.sol
0xng
previously approved these changes
Nov 29, 2023
gas1cent
previously approved these changes
Dec 4, 2023
gas1cent
approved these changes
Dec 4, 2023
0xng
approved these changes
Dec 4, 2023
0xRaccoon
approved these changes
Dec 4, 2023
xorsal
pushed a commit
that referenced
this pull request
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BES-98
Closes BES-147