Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace solhint with solhint-community #59

Merged
merged 5 commits into from
Feb 2, 2024
Merged

feat: replace solhint with solhint-community #59

merged 5 commits into from
Feb 2, 2024

Conversation

dristpunk
Copy link
Contributor

Closes BES-252

@dristpunk dristpunk self-assigned this Jan 31, 2024
@linear Linear
Copy link

linear bot commented Jan 31, 2024

BES-252 Try the community solhint

@dristpunk dristpunk requested review from 0xRaccoon, gas1cent and 0xdeo and removed request for gas1cent February 1, 2024 12:56
@dristpunk dristpunk marked this pull request as ready for review February 1, 2024 12:56
@gas1cent gas1cent requested review from 0xmoebius and removed request for 0xdeo February 1, 2024 13:52
0xRaccoon
0xRaccoon approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@0xRaccoon 0xRaccoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

0xmoebius
0xmoebius approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@0xmoebius 0xmoebius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gas1cent gas1cent merged commit 85943db into main Feb 2, 2024
4 checks passed
@gas1cent gas1cent deleted the feat/solhint-community branch February 2, 2024 17:34
xorsal pushed a commit that referenced this pull request Sep 27, 2024
@0xmoebius
chore: polish helper functions in tests (#59)
06d6863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmoebius 0xmoebius 0xmoebius approved these changes

@0xRaccoon 0xRaccoon 0xRaccoon approved these changes

@gas1cent gas1cent gas1cent approved these changes

Assignees

@dristpunk dristpunk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dristpunk @gas1cent @0xRaccoon @0xmoebius