-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: formal verification & fuzz campaign #69
Conversation
- name: Run Echidna | ||
uses: crytic/echidna-action@v2 | ||
with: | ||
files: . | ||
contract: InvariantGreeter | ||
test-mode: assertion | ||
crytic-args: --ignore-compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would the action look for multiple invariant contracts? Each would have its own step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can pass a directory (in files), contract
is optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can pass a directory
@drgorillamd let's do that? Will be one less thing for whoever starts with the boilerplate to modify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
til: when passing a directory, only the first contract is run, including the import (so here, it tries to run it on IERC20...). For multiple contracts, people are actually using a proxy
Co-authored-by: Gas <[email protected]>
Co-authored-by: Gas <[email protected]>
Co-authored-by: Gas <[email protected]>
Co-authored-by: Gas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@@ -22,7 +22,9 @@ | |||
"lint:sol-tests": "solhint -c .solhint.tests.json 'test/**/*.sol'", | |||
"prepare": "husky install", | |||
"test": "forge test -vvv", | |||
"test:fuzz": "echidna test/invariants/fuzz/Greeter.t.sol --contract GreeterInvariant --corpus-dir test/invariants/fuzz/echidna_coverage/ --test-mode assertion", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use wildcards to run against all contracts under fuzz/
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check the previous comment from gas @0xmoebius ;)
No description provided.