Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade workflows dependencies #71

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Conversation

hexshire
Copy link
Member

No description provided.

gas1cent
gas1cent previously approved these changes Jun 26, 2024
@gas1cent gas1cent requested review from 0xOneTony and 0xteddybear and removed request for turtlemoji, 0xGorilla and simon-something June 26, 2024 16:53
Copy link
Contributor

@0xteddybear 0xteddybear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while all other github workflows already use checkout action v4, they still use node 18, and here the node version is updated to 20. I'd recommend to use the same node version for all workflows by updating coverage_check, canary and release to 20 as well.

just curious, what prompted this update? was checkoutv3 deprecated? did something break?

@hexshire
Copy link
Member Author

while all other github workflows already use checkout action v4, they still use node 18, and here the node version is updated to 20. I'd recommend to use the same node version for all workflows by updating coverage_check, canary and release to 20 as well.

just curious, what prompted this update? was checkoutv3 deprecated? did something break?

I was doing the same on another project that used this boilerplate and I felt like I wanted to update it.

@hexshire hexshire changed the title chore: update test workflow chore: upgrade workflows dependencies Jun 26, 2024
Copy link
Member

@0xOneTony 0xOneTony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you Hex 😄

@gas1cent gas1cent merged commit 2dcd8fa into main Jun 28, 2024
7 checks passed
@gas1cent gas1cent deleted the chore/update-test-workflow branch June 28, 2024 15:39
xorsal pushed a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants