Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump husky version #84

Merged
merged 5 commits into from
Oct 1, 2024
Merged

chore: bump husky version #84

merged 5 commits into from
Oct 1, 2024

Conversation

xorsal
Copy link
Contributor

@xorsal xorsal commented Sep 26, 2024

Bump husky version

  • use husky@>=9
  • upgrade husky scripts, following v9 release notes
  • update yarn.lock file

Copy link
Member

@gas1cent gas1cent Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the prepare command to:

"prepare": "husky",

Note that husky init replaces the content of the pre-commit hook with yarn test which is incorrect.

Copy link
Member

@0xJabberwock 0xJabberwock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gas1cent gas1cent requested a review from wei3erHase September 30, 2024 10:44
Copy link
Member

@wei3erHase wei3erHase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gas1cent gas1cent merged commit 537aac8 into main Oct 1, 2024
7 checks passed
@gas1cent gas1cent deleted the chore/bump-husky branch October 1, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants