Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

General design is not very "ansible like" #42

Open
tobilarscheid opened this issue Jan 11, 2017 · 1 comment
Open

General design is not very "ansible like" #42

tobilarscheid opened this issue Jan 11, 2017 · 1 comment

Comments

@tobilarscheid
Copy link

Hi everyone,

I feel like the general design of the role is not following the normal "ansible way" if there is something like this. What do I mean by this? Checking if something is installed by running into an error is uncommon. Normally in ansible you just specify the desired state and ansible checks if any changes have to be run. Using the standard ansible plugins instead of shell plugins is also recommended wherever possible. I don't how big of a rewrite this would mean for this extension (did not yet look at the code), just wanted to bring up this issue and start a discussion.

Regards,

Tobi

@ant31
Copy link

ant31 commented Apr 4, 2017

Using the standard ansible plugins instead of shell plugins is also recommended wherever possible

Ansible requires python on the target host to be able to use modules. In this case python is not installed, there is no other choices than to use raw.

Checking if something is installed by running into an error

ItIt a quite common pattern. When you have multiple steps to generate an artifact, you first check if the artifact is present.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants