You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.
I feel like the general design of the role is not following the normal "ansible way" if there is something like this. What do I mean by this? Checking if something is installed by running into an error is uncommon. Normally in ansible you just specify the desired state and ansible checks if any changes have to be run. Using the standard ansible plugins instead of shell plugins is also recommended wherever possible. I don't how big of a rewrite this would mean for this extension (did not yet look at the code), just wanted to bring up this issue and start a discussion.
Regards,
Tobi
The text was updated successfully, but these errors were encountered:
Hi everyone,
I feel like the general design of the role is not following the normal "ansible way" if there is something like this. What do I mean by this? Checking if something is installed by running into an error is uncommon. Normally in ansible you just specify the desired state and ansible checks if any changes have to be run. Using the standard ansible plugins instead of shell plugins is also recommended wherever possible. I don't how big of a rewrite this would mean for this extension (did not yet look at the code), just wanted to bring up this issue and start a discussion.
Regards,
Tobi
The text was updated successfully, but these errors were encountered: