test: LoginForm 테스트 및 쿠키 처리 로직 개선 #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
deipanema
commented
Oct 30, 2024
deipanema
commented
- LoginForm.test.tsx에 테스트 추가
- accessToken 추출 로직을 정규식 대신 getCookieValue 함수로 리팩토링
- getCookieValue 함수를 통해 쿠키 값 가져오는 방식 개선
- hook ⇨ hooks로 폴더명 변경 - 로그인 로직을 React Query의 useMutation으로 리팩토링 - 로컬 로그인 오류 상태 관리 제거 - 로그인 실패 시 toast 알림을 통한 오류 처리 추가 - useSignup을 useAuth로 통합하여 인증 처리 통일 - LoginForm 컴포넌트를 새로운 useAuth 훅을 사용하도록 업데이트
- LoginForm.test.tsx에 테스트 추가 - accessToken 추출 로직을 정규식 대신 getCookieValue 함수로 리팩토링 - getCookieValue 함수를 통해 쿠키 값 가져오는 방식 개선
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.