Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[integration][omevv_firmware_repository_profile]: Enhancement of testcases and pre-requisite #764

Merged
merged 8 commits into from
Nov 21, 2024
Merged

[integration][omevv_firmware_repository_profile]: Enhancement of testcases and pre-requisite #764

merged 8 commits into from
Nov 21, 2024

Conversation

ABHISHEK-SINHA10
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

@ansible-collections-svc
Copy link
Collaborator

Can one of the admins verify this patch?

@rajshekarp87 rajshekarp87 added the validation/in-progress Validation is in progress label Nov 13, 2024
@rajshekarp87 rajshekarp87 added this to the v9.9.0 milestone Nov 13, 2024
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 changed the title [omevv_firmware_repository_profile]: Enhancement of testcases and pre-requisite [integration][omevv_firmware_repository_profile]: Enhancement of testcases and pre-requisite Nov 14, 2024
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 removed this from the v9.9.0 milestone Nov 20, 2024
@ABHISHEK-SINHA10
Copy link
Contributor Author

ABHISHEK-SINHA10 commented Nov 20, 2024 •
edited
Loading

Removed from 9.9.0 as there's open defect. Code is completed.

@ABHISHEK-SINHA10 ABHISHEK-SINHA10 added this to the v9.9.0 milestone Nov 21, 2024
@ABHISHEK-SINHA10 ABHISHEK-SINHA10 added validation/completed Validation is completed and removed validation/in-progress Validation is in progress labels Nov 21, 2024
@ABHISHEK-SINHA10
Copy link
Contributor Author

Verfied the defect

@rajshekarp87 rajshekarp87 merged commit ab4b599 into dell:collections Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShivamSh3 ShivamSh3 ShivamSh3 approved these changes

@Kritika-Bhateja-03 Kritika-Bhateja-03 Kritika-Bhateja-03 approved these changes

@rajshekarp87 rajshekarp87 rajshekarp87 approved these changes

@sachin-apa sachin-apa Awaiting requested review from sachin-apa sachin-apa is a code owner

@singh-lovepreet1 singh-lovepreet1 Awaiting requested review from singh-lovepreet1

@Saksham-Nautiyal Saksham-Nautiyal Awaiting requested review from Saksham-Nautiyal

Assignees

@ABHISHEK-SINHA10 ABHISHEK-SINHA10

Labels
validation/completed Validation is completed
Projects
OpenManage Ansible Collection
Status: In progress
Milestone
v9.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ABHISHEK-SINHA10 @ansible-collections-svc @rajshekarp87 @Kritika-Bhateja-03 @ShivamSh3