[Integration][omevv_baseline_profile] - Create, Modify and Delete #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajshekarp87
requested review from
sachin-apa,
ABHISHEK-SINHA10,
Kritika-Bhateja-03 and
ShivamSh3
as code owners
|
Can one of the admins verify this patch? |
tests/integration/targets/omevv_baseline_profile/tests/create_multiple_cluster.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/omevv_baseline_profile/tests/create_multiple_cluster.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/omevv_baseline_profile/tests/create_single_cluster.yaml
Outdated
Show resolved
Hide resolved
rajshekarp87
force-pushed
the
integration/omevv_baseline_profile
branch
from
f512504
to
4c0788c
Compare
tests/integration/targets/omevv_baseline_profile/tests/create_single_cluster.yaml
Outdated
Show resolved
Hide resolved
ABHISHEK-SINHA10
requested changes
Nov 19, 2024
| name: OMAM_Baseline_Profile | ||
| repository_profile: OMAM_Firm_Repo | ||
| cluster: | ||
| - OMAM-Cluster-1 |
There was a problem hiding this comment.
why are we hardcoding cluster name, are we in assumption all the OMEVV setup has same cluster name, please check once.
There was a problem hiding this comment.
This will be prerequisite before running the suite
There was a problem hiding this comment.
as we discussed we should have dynamic fetching of cluster name as OMEVV has API to fetch it
tests/integration/targets/omevv_baseline_profile/tests/create_single_cluster.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/omevv_baseline_profile/tests/modify.yml
Outdated
Show resolved
Hide resolved
|
Please add negative scenarios, I think it's missing. |
sachin-apa
reviewed
Nov 21, 2024
tests/integration/targets/omevv_baseline_profile/tests/create_single_cluster.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/omevv_baseline_profile/tests/create_multiple_cluster.yaml
Outdated
Show resolved
Hide resolved
| that: | ||
| - cm_dm_result_baseline.changed | ||
| - 'cm_dm_result_baseline.msg == "Changes found to be applied."' | ||
| - cm_dm_result_baseline.diff.before | length > 1 |
There was a problem hiding this comment.
Can we compare the fields instead of just length.
tests/integration/targets/omevv_baseline_profile/tests/modify.yml
Outdated
Show resolved
Hide resolved
rajshekarp87
added
validation/completed
|
please add negative scenarios for create, modify and delete too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
GitHub Issues
List the GitHub issues impacted by this PR:
ISSUE TYPE
COMPONENT NAME
OUTPUT
ADDITIONAL INFORMATION
Checklist: