-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replication observability metrics #142
Conversation
412cfdd
to
a56eb51
Compare
metrics.go
Outdated
// VolumeMirrorTransferRate - Volume Mirror Transfer Rate | ||
func (c *ClientIMPL) VolumeMirrorTransferRate(ctx context.Context, entityID string) ([]VolumeMirrorTransferRateResponse, error) { | ||
var resp []VolumeMirrorTransferRateResponse | ||
err := c.mirrorTransferRate(ctx, &resp, entityID, 2000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this 2000
be a constant value instead of hardcoding it here like this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
863ab1e
to
04451e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
if err != nil { | ||
err = WrapErr(err) | ||
} | ||
customHeader.Del("DELL-VISIBILITY") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
customHeader.Del("DELL-VISIBILITY") | |
customHeader.Del("DELL-VISIBILITY") | |
apiClient.SetCustomHTTPHeaders(customHeader) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
PR Submission checklist
It enables API support for volume_mirror_transfer_rate_cma_view which will be helpful to pull the Replication related stats for Sync and Metro at volume level.
GitHub Issues
List the GitHub issues impacted by this PR:
Common PR Checklist:
Description of your changes:
Earlier unit-test report
Current unit-test report