From e84ed7f6afbfc8257cfd1d451a00c81b6de4d630 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 13:57:00 +0530 Subject: [PATCH 01/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index bc140723d..089da6d3f 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -25,6 +25,14 @@ jobs: # Important: This sets up your GITHUB_WORKSPACE environment variable - uses: actions/checkout@v2 + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: 3.11 + + - name: Install ansible lint + run: pip install ansible-lint==6.22.0 + - name: ansible-lint # replace "master" with any valid ref uses: ansible/ansible-lint-action@c37fb7b4bda2c8cb18f4942716bae9f11b0dc9bc @@ -67,8 +75,8 @@ jobs: # Arguments to override a package and its version to be set explicitly. # Must follow the example syntax. override-deps: | - ansible==6.7.0 - ansible-lint==6.13.1 + ansible==9.5.1 + ansible-lint==6.22 # [optional] # Arguments to be passed to the ansible-lint From a939d4530bd4de9b8cf8e4d06b1389ad3797d929 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 14:00:53 +0530 Subject: [PATCH 02/48] Update omnia.yml --- omnia.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/omnia.yml b/omnia.yml index 0ba2c19b2..fc6215a84 100644 --- a/omnia.yml +++ b/omnia.yml @@ -17,6 +17,15 @@ ansible.builtin.import_playbook: utils/check_venv.yml when: not ( check_venv_executed | default(false) | bool ) +- name: Set flag + hosts: localhost + connection: local + gather_facts: false + tasks: + - name: Set flag to indicate check_venv.yml has been executed + ansible.builtin.set_fact: + check_venv_executed: true + - name: Check if package manager is not locked ansible.builtin.import_playbook: utils/check_package_lock.yml when: not ( hostvars['127.0.0.1']['apt_lock_status'] | default(false) | bool ) From a90d85994a162d9f01a080bc0ce3f0b6ae793d6f Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 14:01:43 +0530 Subject: [PATCH 03/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 089da6d3f..5d2914080 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -15,6 +15,7 @@ on: - release-1.5.1 - release-1.6 - release-1.7 + - pub/new_architecture jobs: ansible-lint: From 2b6cfecb7effe829d3be098efbb472d388999cd8 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 14:07:25 +0530 Subject: [PATCH 04/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 5d2914080..311760138 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -76,7 +76,8 @@ jobs: # Arguments to override a package and its version to be set explicitly. # Must follow the example syntax. override-deps: | - ansible==9.5.1 + ansible==2.16.13 + ansible-core==9.5.1 ansible-lint==6.22 # [optional] # Arguments to be passed to the ansible-lint From 52b840cb7b77af3ec5b06e861a20a22097d6a437 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 14:10:09 +0530 Subject: [PATCH 05/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 311760138..d464179a4 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -76,8 +76,7 @@ jobs: # Arguments to override a package and its version to be set explicitly. # Must follow the example syntax. override-deps: | - ansible==2.16.13 - ansible-core==9.5.1 + ansible==6.7.0 ansible-lint==6.22 # [optional] # Arguments to be passed to the ansible-lint From 188f840800768935625b443ba5356e9d6d6d9f03 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 14:24:37 +0530 Subject: [PATCH 06/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index d464179a4..c2b078b73 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -36,7 +36,7 @@ jobs: - name: ansible-lint # replace "master" with any valid ref - uses: ansible/ansible-lint-action@c37fb7b4bda2c8cb18f4942716bae9f11b0dc9bc + uses: ansible/ansible-lint@main with: # [required] # Paths to ansible files (i.e., playbooks, tasks, handlers etc..) From 19e6e575d772cb43f4d71566a681c43c1a9e9258 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 14:28:31 +0530 Subject: [PATCH 07/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index c2b078b73..48814db64 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -34,9 +34,9 @@ jobs: - name: Install ansible lint run: pip install ansible-lint==6.22.0 - - name: ansible-lint + - name: run-ansible-lint # replace "master" with any valid ref - uses: ansible/ansible-lint@main + uses: ansible/ansible-lint@v6.22.0 with: # [required] # Paths to ansible files (i.e., playbooks, tasks, handlers etc..) From 21525d6e4a5a7bc67ab291281a99d4ccbff6cdf2 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 14:41:34 +0530 Subject: [PATCH 08/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 104 +++++++++-------------------- 1 file changed, 32 insertions(+), 72 deletions(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 48814db64..bfb5b513d 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -18,26 +18,10 @@ on: - pub/new_architecture jobs: - ansible-lint: - + build: + name: Ansible Lint # Naming the build is important to use it as a status check runs-on: ubuntu-latest - steps: - # Important: This sets up your GITHUB_WORKSPACE environment variable - - uses: actions/checkout@v2 - - - name: Set up Python - uses: actions/setup-python@v4 - with: - python-version: 3.11 - - - name: Install ansible lint - run: pip install ansible-lint==6.22.0 - - - name: run-ansible-lint - # replace "master" with any valid ref - uses: ansible/ansible-lint@v6.22.0 - with: # [required] # Paths to ansible files (i.e., playbooks, tasks, handlers etc..) # or valid Ansible directories according to the Ansible role @@ -46,58 +30,34 @@ jobs: # targets: | # playbook_1.yml # playbook_2.yml - targets: | - /github/workspace/omnia.yml - /github/workspace/discovery_provision.yml - /github/workspace/local_repo/local_repo.yml - /github/workspace/server_spec_update/server_spec_update.yml - /github/workspace/scheduler/job_based_user_access.yml - /github/workspace/security/user_passwordless_ssh.yml - /github/workspace/storage/nfs_sas.yml - /github/workspace/storage/powervault.yml - /github/workspace/telemetry/add_node_idrac.yml - /github/workspace/tools/jupyterhub.yml - /github/workspace/tools/kserve.yml - /github/workspace/tools/kubeflow.yml - /github/workspace/tools/pytorch.yml - /github/workspace/tools/tensorflow.yml - /github/workspace/tools/vllm.yml - /github/workspace/utils/control_plane_cleanup.yml - /github/workspace/utils/delete_node.yml - /github/workspace/utils/remove_node_configuration.yml - /github/workspace/utils/reset_cluster_configuration.yml - /github/workspace/utils/update_user_repo.yml - /github/workspace/utils/servicetag_host_mapping.yml - /github/workspace/utils/software_update/software_update.yml - /github/workspace/utils/timescaledb_utility/timescaledb_utility.yml - /github/workspace/utils/ip_rule_assignment/ip_rule_assignment.yml - /github/workspace/utils/nodeinfo_db/nodeinfo_db.yml - # [optional] - # Arguments to override a package and its version to be set explicitly. - # Must follow the example syntax. - override-deps: | - ansible==6.7.0 - ansible-lint==6.22 - # [optional] - # Arguments to be passed to the ansible-lint + - uses: actions/checkout@v4 + - name: Run ansible-lint + uses: ansible/ansible-lint@main # or version tag instead of 'main' + # targets: | + # /github/workspace/omnia.yml + # /github/workspace/discovery_provision.yml + # /github/workspace/local_repo/local_repo.yml + # /github/workspace/server_spec_update/server_spec_update.yml + # /github/workspace/scheduler/job_based_user_access.yml + # /github/workspace/security/user_passwordless_ssh.yml + # /github/workspace/storage/nfs_sas.yml + # /github/workspace/storage/powervault.yml + # /github/workspace/telemetry/add_node_idrac.yml + # /github/workspace/tools/jupyterhub.yml + # /github/workspace/tools/kserve.yml + # /github/workspace/tools/kubeflow.yml + # /github/workspace/tools/pytorch.yml + # /github/workspace/tools/tensorflow.yml + # /github/workspace/tools/vllm.yml + # /github/workspace/utils/control_plane_cleanup.yml + # /github/workspace/utils/delete_node.yml + # /github/workspace/utils/remove_node_configuration.yml + # /github/workspace/utils/reset_cluster_configuration.yml + # /github/workspace/utils/update_user_repo.yml + # /github/workspace/utils/servicetag_host_mapping.yml + # /github/workspace/utils/software_update/software_update.yml + # /github/workspace/utils/timescaledb_utility/timescaledb_utility.yml + # /github/workspace/utils/ip_rule_assignment/ip_rule_assignment.yml + # /github/workspace/utils/nodeinfo_db/nodeinfo_db.yml + # # [optional] - # Options: - # -q quieter, although not silent output - # -p parseable output in the format of pep8 - # --parseable-severity parseable output including severity of rule - # -r RULESDIR specify one or more rules directories using one or - # more -r arguments. Any -r flags override the default - # rules in ansiblelint/rules, unless -R is also used. - # -R Use default rules in ansiblelint/rules in addition to - # any extra - # rules directories specified with -r. There is no need - # to specify this if no -r flags are used - # -t TAGS only check rules whose id/tags match these values - # -x SKIP_LIST only check rules whose id/tags do not match these - # values - # --nocolor disable colored output - # --exclude=EXCLUDE_PATHS - # path to directories or files to skip. This option is - # repeatable. - # -c C Specify configuration file to use. Defaults to ".ansible-lint" - args: "-x 305" From 8189887123096b3e8fc6030b7567e1cdeb602a51 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:06:32 +0530 Subject: [PATCH 09/48] Ansible lint workflow --- .github/workflows/.ansible-lint.yml | 24 ++++++++++++++++++++++++ .github/workflows/ansible-lint.yml | 29 ++--------------------------- 2 files changed, 26 insertions(+), 27 deletions(-) create mode 100644 .github/workflows/.ansible-lint.yml diff --git a/.github/workflows/.ansible-lint.yml b/.github/workflows/.ansible-lint.yml new file mode 100644 index 000000000..06dd5da43 --- /dev/null +++ b/.github/workflows/.ansible-lint.yml @@ -0,0 +1,24 @@ +exclude_paths: + - .git + - .github + - test + - utils/test + - docs + - test + - examples + +warn_list: + - yaml + - meta-no-info + - meta-incorrect + - fqcn-builtins + +skip_list: + - experimental + - no-changed-when + - command-instead-of-module + +verbosity: 1 + +# Set the format of lint output +format: full \ No newline at end of file diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index bfb5b513d..5d4175eec 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -33,31 +33,6 @@ jobs: - uses: actions/checkout@v4 - name: Run ansible-lint uses: ansible/ansible-lint@main # or version tag instead of 'main' - # targets: | - # /github/workspace/omnia.yml - # /github/workspace/discovery_provision.yml - # /github/workspace/local_repo/local_repo.yml - # /github/workspace/server_spec_update/server_spec_update.yml - # /github/workspace/scheduler/job_based_user_access.yml - # /github/workspace/security/user_passwordless_ssh.yml - # /github/workspace/storage/nfs_sas.yml - # /github/workspace/storage/powervault.yml - # /github/workspace/telemetry/add_node_idrac.yml - # /github/workspace/tools/jupyterhub.yml - # /github/workspace/tools/kserve.yml - # /github/workspace/tools/kubeflow.yml - # /github/workspace/tools/pytorch.yml - # /github/workspace/tools/tensorflow.yml - # /github/workspace/tools/vllm.yml - # /github/workspace/utils/control_plane_cleanup.yml - # /github/workspace/utils/delete_node.yml - # /github/workspace/utils/remove_node_configuration.yml - # /github/workspace/utils/reset_cluster_configuration.yml - # /github/workspace/utils/update_user_repo.yml - # /github/workspace/utils/servicetag_host_mapping.yml - # /github/workspace/utils/software_update/software_update.yml - # /github/workspace/utils/timescaledb_utility/timescaledb_utility.yml - # /github/workspace/utils/ip_rule_assignment/ip_rule_assignment.yml - # /github/workspace/utils/nodeinfo_db/nodeinfo_db.yml - # # [optional] + with: + path: . From 9378bfebd3c83fbe7fac839926b4c36bd3c73624 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:09:30 +0530 Subject: [PATCH 10/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 5d4175eec..e8da788cf 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -32,7 +32,7 @@ jobs: # playbook_2.yml - uses: actions/checkout@v4 - name: Run ansible-lint - uses: ansible/ansible-lint@main # or version tag instead of 'main' + uses: ansible/ansible-lint@v6.22.0 with: path: . From 0a2e6bb58f54b3bc5bd03ea0b0c6ad731159638d Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:12:04 +0530 Subject: [PATCH 11/48] Update .ansible-lint.yml --- .github/workflows/.ansible-lint.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/.ansible-lint.yml b/.github/workflows/.ansible-lint.yml index 06dd5da43..607998218 100644 --- a/.github/workflows/.ansible-lint.yml +++ b/.github/workflows/.ansible-lint.yml @@ -1,11 +1,11 @@ exclude_paths: - - .git - - .github - - test - - utils/test - - docs - - test - - examples + - .git/ + - .github/ + - test/ + - utils/test/ + - docs/ + - test/ + - examples/ warn_list: - yaml From fa5620a20d48a6a3151e5d67c517de035241cdfe Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:16:38 +0530 Subject: [PATCH 12/48] Update .ansible-lint.yml --- .github/workflows/.ansible-lint.yml => .ansible-lint.yml | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/.ansible-lint.yml => .ansible-lint.yml (100%) diff --git a/.github/workflows/.ansible-lint.yml b/.ansible-lint.yml similarity index 100% rename from .github/workflows/.ansible-lint.yml rename to .ansible-lint.yml From 7910ba52042e171fb25a5c367cc3d6aa34b3100a Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:24:05 +0530 Subject: [PATCH 13/48] Update .ansible-lint.yml --- .ansible-lint.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.ansible-lint.yml b/.ansible-lint.yml index 607998218..9ed68bd18 100644 --- a/.ansible-lint.yml +++ b/.ansible-lint.yml @@ -19,6 +19,4 @@ skip_list: - command-instead-of-module verbosity: 1 - -# Set the format of lint output -format: full \ No newline at end of file +profile: production From 97842144f469b45f223ad156c901427c10c2e176 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:26:13 +0530 Subject: [PATCH 14/48] Update .ansible-lint.yml --- .ansible-lint.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.ansible-lint.yml b/.ansible-lint.yml index 9ed68bd18..abff38259 100644 --- a/.ansible-lint.yml +++ b/.ansible-lint.yml @@ -6,6 +6,8 @@ exclude_paths: - docs/ - test/ - examples/ + - .ansible-lint.yml + - .readthedocs.yaml warn_list: - yaml From 5903c05f98bd24fbc12efdd30c5cdde696572568 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:27:23 +0530 Subject: [PATCH 15/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index e8da788cf..5b2d08d2a 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -33,6 +33,3 @@ jobs: - uses: actions/checkout@v4 - name: Run ansible-lint uses: ansible/ansible-lint@v6.22.0 - with: - path: . - From 2b319d3ddb83459e5523f36499c7538837a8a3f1 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:27:47 +0530 Subject: [PATCH 16/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 5b2d08d2a..89f62b813 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -15,6 +15,8 @@ on: - release-1.5.1 - release-1.6 - release-1.7 + - staging + - release-1.7.1 - pub/new_architecture jobs: From b8513a126e7d2eeda7af4e758fc51ead275cc246 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:46:57 +0530 Subject: [PATCH 17/48] Lint fix --- .ansible-lint.yml | 1 + .github/workflows/ansible-lint.yml | 10 +--------- .readthedocs.yaml | 8 ++++---- 3 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.ansible-lint.yml b/.ansible-lint.yml index abff38259..04dbc0802 100644 --- a/.ansible-lint.yml +++ b/.ansible-lint.yml @@ -8,6 +8,7 @@ exclude_paths: - examples/ - .ansible-lint.yml - .readthedocs.yaml + - accelerator/tests warn_list: - yaml diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 89f62b813..702edf2b9 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -17,21 +17,13 @@ on: - release-1.7 - staging - release-1.7.1 - - pub/new_architecture + - pub/new_architecture jobs: build: name: Ansible Lint # Naming the build is important to use it as a status check runs-on: ubuntu-latest steps: - # [required] - # Paths to ansible files (i.e., playbooks, tasks, handlers etc..) - # or valid Ansible directories according to the Ansible role - # directory structure. - # If you want to lint multiple ansible files, use the following syntax - # targets: | - # playbook_1.yml - # playbook_2.yml - uses: actions/checkout@v4 - name: Run ansible-lint uses: ansible/ansible-lint@v6.22.0 diff --git a/.readthedocs.yaml b/.readthedocs.yaml index 978578b37..2601b7d62 100644 --- a/.readthedocs.yaml +++ b/.readthedocs.yaml @@ -21,11 +21,11 @@ sphinx: # If using Sphinx, optionally build your docs in additional formats such as PDF formats: - - pdf - - epub - - htmlzip + - pdf + - epub + - htmlzip # Optionally declare the Python requirements required to build your docs python: install: - - requirements: docs/source/requirements.txt \ No newline at end of file + - requirements: docs/source/requirements.txt From af666b722347cc7f3e8aea5b00ce274e9d9101df Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:47:31 +0530 Subject: [PATCH 18/48] Update omnia.yml --- omnia.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/omnia.yml b/omnia.yml index fc6215a84..0ba2c19b2 100644 --- a/omnia.yml +++ b/omnia.yml @@ -17,15 +17,6 @@ ansible.builtin.import_playbook: utils/check_venv.yml when: not ( check_venv_executed | default(false) | bool ) -- name: Set flag - hosts: localhost - connection: local - gather_facts: false - tasks: - - name: Set flag to indicate check_venv.yml has been executed - ansible.builtin.set_fact: - check_venv_executed: true - - name: Check if package manager is not locked ansible.builtin.import_playbook: utils/check_package_lock.yml when: not ( hostvars['127.0.0.1']['apt_lock_status'] | default(false) | bool ) From fe95b472df77446cba3dfd7183fd567fb79af731 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:54:57 +0530 Subject: [PATCH 19/48] Update .ansible-lint.yml --- .ansible-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ansible-lint.yml b/.ansible-lint.yml index 04dbc0802..755c03d9b 100644 --- a/.ansible-lint.yml +++ b/.ansible-lint.yml @@ -8,7 +8,7 @@ exclude_paths: - examples/ - .ansible-lint.yml - .readthedocs.yaml - - accelerator/tests + - accelerator/tests/ warn_list: - yaml From 35298d24d588c0eb932ad0b05076485742902288 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 15:59:24 +0530 Subject: [PATCH 20/48] Update .ansible-lint.yml --- .ansible-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ansible-lint.yml b/.ansible-lint.yml index 755c03d9b..7d9843c05 100644 --- a/.ansible-lint.yml +++ b/.ansible-lint.yml @@ -6,9 +6,9 @@ exclude_paths: - docs/ - test/ - examples/ + - accelerator/tests/ - .ansible-lint.yml - .readthedocs.yaml - - accelerator/tests/ warn_list: - yaml From af693c8a090505e021cdf674faa18ce9be8e45dc Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:04:27 +0530 Subject: [PATCH 21/48] Update .ansible-lint.yml --- .ansible-lint.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.ansible-lint.yml b/.ansible-lint.yml index 7d9843c05..39754dc91 100644 --- a/.ansible-lint.yml +++ b/.ansible-lint.yml @@ -1,12 +1,12 @@ exclude_paths: - .git/ - .github/ + - accelerator/tests/ - test/ - utils/test/ - docs/ - test/ - examples/ - - accelerator/tests/ - .ansible-lint.yml - .readthedocs.yaml @@ -16,10 +16,10 @@ warn_list: - meta-incorrect - fqcn-builtins -skip_list: - - experimental - - no-changed-when - - command-instead-of-module +# skip_list: +# - experimental +# - no-changed-when +# - command-instead-of-module verbosity: 1 profile: production From c6a4612575dd04e5adfb29f61199ce3699ecf471 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:11:05 +0530 Subject: [PATCH 22/48] Update .ansible-lint.yml --- .ansible-lint.yml => .config/.ansible-lint.yml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) rename .ansible-lint.yml => .config/.ansible-lint.yml (75%) diff --git a/.ansible-lint.yml b/.config/.ansible-lint.yml similarity index 75% rename from .ansible-lint.yml rename to .config/.ansible-lint.yml index 39754dc91..7957467f0 100644 --- a/.ansible-lint.yml +++ b/.config/.ansible-lint.yml @@ -1,3 +1,4 @@ +--- exclude_paths: - .git/ - .github/ @@ -16,10 +17,5 @@ warn_list: - meta-incorrect - fqcn-builtins -# skip_list: -# - experimental -# - no-changed-when -# - command-instead-of-module - verbosity: 1 profile: production From e820ca65c7d30ad72696103d2f24cf615fd5837b Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:11:52 +0530 Subject: [PATCH 23/48] Update ansible-lint.yml --- .config/{.ansible-lint.yml => ansible-lint.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .config/{.ansible-lint.yml => ansible-lint.yml} (100%) diff --git a/.config/.ansible-lint.yml b/.config/ansible-lint.yml similarity index 100% rename from .config/.ansible-lint.yml rename to .config/ansible-lint.yml From 4ccbe9f545e98a25cf3b248fb03c54d64e5ee7f0 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:19:15 +0530 Subject: [PATCH 24/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 7957467f0..f44ab7e72 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -2,7 +2,7 @@ exclude_paths: - .git/ - .github/ - - accelerator/tests/ + - accelerator/tests - test/ - utils/test/ - docs/ From 26f7583fc0e94cebf746ccd92dc0334675e8d222 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:23:26 +0530 Subject: [PATCH 25/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 702edf2b9..e464e5efb 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -27,3 +27,5 @@ jobs: - uses: actions/checkout@v4 - name: Run ansible-lint uses: ansible/ansible-lint@v6.22.0 + with: + args: --config=.config/ansible-lint.yml From c25e4b0ac1edfd978260adc663c41045d93761e3 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:29:43 +0530 Subject: [PATCH 26/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index f44ab7e72..67a9deb88 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -2,7 +2,7 @@ exclude_paths: - .git/ - .github/ - - accelerator/tests + - accelerator/tests/ - test/ - utils/test/ - docs/ @@ -17,5 +17,8 @@ warn_list: - meta-incorrect - fqcn-builtins +skip_list: + - var-naming[no-role-prefix] + verbosity: 1 profile: production From 7ed8de1b3b466797e7d1015b1009b45f5c07c029 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:41:16 +0530 Subject: [PATCH 27/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 67a9deb88..0d08890ac 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -3,10 +3,12 @@ exclude_paths: - .git/ - .github/ - accelerator/tests/ + - network/tests/ - test/ - utils/test/ - docs/ - test/ + - platforms/ - examples/ - .ansible-lint.yml - .readthedocs.yaml From 3bb2cb2c1680da5676210c62eedaee16e257560c Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:46:39 +0530 Subject: [PATCH 28/48] OIM Omnia container startup script --- .config/ansible-lint.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 0d08890ac..b6a03f87f 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -4,6 +4,10 @@ exclude_paths: - .github/ - accelerator/tests/ - network/tests/ + - provision/tests/ + - scheduler/tests/ + - security/tests/ + - storage/tests/ - test/ - utils/test/ - docs/ From e85504204a5780fde13728f4002004e7422ae112 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:52:42 +0530 Subject: [PATCH 29/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index b6a03f87f..93a2ee73c 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -25,6 +25,7 @@ warn_list: skip_list: - var-naming[no-role-prefix] + - syntax-check[unknown-module] verbosity: 1 profile: production From 1de3425b483e3d977265ba6937365e4c51caa89c Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 16:58:38 +0530 Subject: [PATCH 30/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 1 - .github/workflows/ansible-lint.yml | 11 ++++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 93a2ee73c..b6a03f87f 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -25,7 +25,6 @@ warn_list: skip_list: - var-naming[no-role-prefix] - - syntax-check[unknown-module] verbosity: 1 profile: production diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index e464e5efb..49c446129 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -24,7 +24,16 @@ jobs: name: Ansible Lint # Naming the build is important to use it as a status check runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - name: Checkout repository + uses: actions/checkout@v4 + + - name: Install Ansible collections + run: | + python3 -m pip install --upgrade pip + pip install ansible + ansible-galaxy collection install dellemc.os10 + ansible-galaxy collection install community.general + - name: Run ansible-lint uses: ansible/ansible-lint@v6.22.0 with: From 5e162d377a111ab7076aa9e1b4eec393206cb165 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Wed, 29 Jan 2025 17:06:41 +0530 Subject: [PATCH 31/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 3 +++ .github/workflows/ansible-lint.yml | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index b6a03f87f..66cb069c4 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -10,6 +10,9 @@ exclude_paths: - storage/tests/ - test/ - utils/test/ + - utils/obsolete/ + - utils/cluster/ + - utils/k8s-upgrade/ - docs/ - test/ - platforms/ diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 49c446129..aafe615cf 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -31,7 +31,6 @@ jobs: run: | python3 -m pip install --upgrade pip pip install ansible - ansible-galaxy collection install dellemc.os10 ansible-galaxy collection install community.general - name: Run ansible-lint From 335ca0fa1a8ec2ae204b8d7b20a8b545b2f660be Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 10:35:15 +0530 Subject: [PATCH 32/48] lint fix --- .../roles/intel/tasks/make_sure_scale_out_interfaces_up.yml | 1 - accelerator/roles/nvidia/tasks/install_cuda_redhat.yml | 4 ++-- .../roles/configure_xcat/redhat/tasks/omnia_repo_config.yml | 2 +- discovery/roles/configure_xcat/ubuntu/tasks/racadm_config.yml | 2 +- discovery/roles/configure_xcat/ubuntu/vars/main.yml | 3 +-- discovery/roles/discovery_mechanism/common/vars/main.yml | 2 +- discovery/roles/os_update/tasks/set_kernel_params.yml | 2 +- discovery/roles/postscripts/common/vars/main.yml | 2 +- discovery_provision.yml | 2 +- 9 files changed, 9 insertions(+), 11 deletions(-) diff --git a/accelerator/roles/intel/tasks/make_sure_scale_out_interfaces_up.yml b/accelerator/roles/intel/tasks/make_sure_scale_out_interfaces_up.yml index fb6cda55c..7c347307f 100644 --- a/accelerator/roles/intel/tasks/make_sure_scale_out_interfaces_up.yml +++ b/accelerator/roles/intel/tasks/make_sure_scale_out_interfaces_up.yml @@ -76,4 +76,3 @@ name: "Bring up Gaudi ports" special_time: reboot job: "{{ intel_bring_up_ports_script_path }}" - diff --git a/accelerator/roles/nvidia/tasks/install_cuda_redhat.yml b/accelerator/roles/nvidia/tasks/install_cuda_redhat.yml index f08f1bb0f..09d6f930e 100644 --- a/accelerator/roles/nvidia/tasks/install_cuda_redhat.yml +++ b/accelerator/roles/nvidia/tasks/install_cuda_redhat.yml @@ -30,7 +30,7 @@ changed_when: true - name: Enable EPEL Repo - ansible.builtin.yum: + ansible.builtin.yum: # noqa fqcn[action-core] name: https://dl.fedoraproject.org/pub/epel/epel-release-latest-8.noarch.rpm state: present disable_gpg_check: true @@ -39,7 +39,7 @@ when: hostvars['localhost']['local_installer'] block: - name: Install packages from cuda rpm file - ansible.builtin.yum: + ansible.builtin.yum: # noqa fqcn[action-core] name: "{{ cuda_filepath }}" state: present disable_gpg_check: true diff --git a/discovery/roles/configure_xcat/redhat/tasks/omnia_repo_config.yml b/discovery/roles/configure_xcat/redhat/tasks/omnia_repo_config.yml index 6925692dd..0839bab9b 100644 --- a/discovery/roles/configure_xcat/redhat/tasks/omnia_repo_config.yml +++ b/discovery/roles/configure_xcat/redhat/tasks/omnia_repo_config.yml @@ -70,7 +70,7 @@ dest: "{{ omnia_common_xcat_repo }}" mode: "{{ file_permission }}" rescue: - - name: Warning - Failed to download racadm package + - name: Warning - Failed to download racadm package ansible.builtin.pause: prompt: "{{ download_racadm_warning_msg }}" seconds: "{{ warning_time }}" diff --git a/discovery/roles/configure_xcat/ubuntu/tasks/racadm_config.yml b/discovery/roles/configure_xcat/ubuntu/tasks/racadm_config.yml index 00f58e510..ad9dac024 100644 --- a/discovery/roles/configure_xcat/ubuntu/tasks/racadm_config.yml +++ b/discovery/roles/configure_xcat/ubuntu/tasks/racadm_config.yml @@ -30,7 +30,7 @@ until: download_racadm is not failed retries: "{{ max_retries }}" rescue: - - name: Warning - Failed to download racadm package + - name: Warning - Failed to download racadm package ansible.builtin.pause: prompt: "{{ download_racadm_warning_msg }}" seconds: "{{ warning_time }}" diff --git a/discovery/roles/configure_xcat/ubuntu/vars/main.yml b/discovery/roles/configure_xcat/ubuntu/vars/main.yml index 361910af5..cfde74f03 100644 --- a/discovery/roles/configure_xcat/ubuntu/vars/main.yml +++ b/discovery/roles/configure_xcat/ubuntu/vars/main.yml @@ -44,8 +44,7 @@ racadm_tar_url: "https://dl.dell.com/FOLDER08952875M/1/Dell-iDRACTools-Web-LX-11 tarball_path: "{{ repo_store_path }}/cluster/tarball/" racadm_tar_dest: "{{ tarball_path }}/racadm.tar.gz" max_retries: 10 -download_racadm_warning_msg: "[WARNING] Failed to download racadm package {{ racadm_tar_url }}. This can be due to internet connectivity issue. Please verify the connectivity and try again. -Skipping racadm configuration in the cluster." +download_racadm_warning_msg: "[WARNING] Failed to download racadm package {{ racadm_tar_url }}. This can be due to internet connectivity issue. Please verify the connectivity and try again. Skipping racadm configuration in the cluster." # noqa yaml[line-length] warning_time: 30 # Usage: configure_kernel.yml diff --git a/discovery/roles/discovery_mechanism/common/vars/main.yml b/discovery/roles/discovery_mechanism/common/vars/main.yml index 57bc388e6..70a792108 100644 --- a/discovery/roles/discovery_mechanism/common/vars/main.yml +++ b/discovery/roles/discovery_mechanism/common/vars/main.yml @@ -31,6 +31,6 @@ dns_config_warning_msg: "[WARNING] makedns -n command is not successful. Error:" xcat_sbin_path: /opt/xcat/sbin # Usage: remove_old_ssh_key.yml -empty_discover_node_msg: | +empty_discover_node_msg: | "Failed. No nodes were discovered. Please ensure the input related to discovery details is correct inside provision_config.yml and network_spec.yml and check if IPMI is enabled on the nodes if using BMC discovery mechanism." diff --git a/discovery/roles/os_update/tasks/set_kernel_params.yml b/discovery/roles/os_update/tasks/set_kernel_params.yml index ba6d42b90..9e3202dd1 100644 --- a/discovery/roles/os_update/tasks/set_kernel_params.yml +++ b/discovery/roles/os_update/tasks/set_kernel_params.yml @@ -54,7 +54,7 @@ when: cmdline_value != "" block: - name: Servicetag Host mapping and run chdef command - ansible.builtin.command: "{{ python_version }} {{ servicetag_node_mapping_script }} {{ role_path }} {{ file_path }} {{ inventory_hostname_short }} {{ cmdline_value | quote }}" + ansible.builtin.command: "{{ python_version }} {{ servicetag_node_mapping_script }} {{ role_path }} {{ file_path }} {{ inventory_hostname_short }} {{ cmdline_value | quote }}" # noqa yaml[line-length] register: chdef_result changed_when: true diff --git a/discovery/roles/postscripts/common/vars/main.yml b/discovery/roles/postscripts/common/vars/main.yml index d903448c4..903fd7678 100644 --- a/discovery/roles/postscripts/common/vars/main.yml +++ b/discovery/roles/postscripts/common/vars/main.yml @@ -38,7 +38,7 @@ ubuntu_reboot_script_path: # Usage: configure_postsctipts_ntp.yml setup_ntp_warning_msg: "[WARNING] Failed to setup NTP server in Omnia Infrastructure Manager. This can be due to public NTP pools blocked via ICMP. -Skipping NTP configuration in the cluster. If public NTP pools not reachable from Omnia Infrastructure Manager, set ntp_support to false in provison_config.yml." +Skipping NTP configuration in the cluster. If public NTP pools not reachable from Omnia Infrastructure Manager, set ntp_support to false in provison_config.yml." # noqa yaml[line-length] warning_time: 30 async_time: 300 poll_time: 15 diff --git a/discovery_provision.yml b/discovery_provision.yml index c3749e8bc..6a2cebf78 100644 --- a/discovery_provision.yml +++ b/discovery_provision.yml @@ -32,7 +32,7 @@ - name: Set flag to indicate check_package_lock.yml has been executed ansible.builtin.set_fact: apt_lock_status: true - + - name: Set inventory_status ansible.builtin.set_fact: inventory_status: true From 03c0a2e53072512beb4beee1e85476c9b9bf7318 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 10:41:11 +0530 Subject: [PATCH 33/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 66cb069c4..09438dc76 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -15,6 +15,7 @@ exclude_paths: - utils/k8s-upgrade/ - docs/ - test/ + - input/ - platforms/ - examples/ - .ansible-lint.yml @@ -28,6 +29,7 @@ warn_list: skip_list: - var-naming[no-role-prefix] + - fqcn[action-core] verbosity: 1 profile: production From 6eac3d0283097ed8128f2d1a84fad76d84f7256b Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 10:50:18 +0530 Subject: [PATCH 34/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 09438dc76..eaf3c00da 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -30,6 +30,7 @@ warn_list: skip_list: - var-naming[no-role-prefix] - fqcn[action-core] + - syntax-check[missing-file] verbosity: 1 profile: production From 61fbfed8719c6efa08cf7cccbc4cfa2ebd8f17f4 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 10:52:45 +0530 Subject: [PATCH 35/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index eaf3c00da..09438dc76 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -30,7 +30,6 @@ warn_list: skip_list: - var-naming[no-role-prefix] - fqcn[action-core] - - syntax-check[missing-file] verbosity: 1 profile: production From 2dfb68fc449816ade0bc737fbfc21e71d314ebd9 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:04:24 +0530 Subject: [PATCH 36/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 09438dc76..b79111adc 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -30,6 +30,7 @@ warn_list: skip_list: - var-naming[no-role-prefix] - fqcn[action-core] + - unresolved-module verbosity: 1 profile: production From d770e5423267fdd65aae309f4ba9fcb529edf858 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:12:15 +0530 Subject: [PATCH 37/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index aafe615cf..e3a4ff64e 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -34,6 +34,6 @@ jobs: ansible-galaxy collection install community.general - name: Run ansible-lint - uses: ansible/ansible-lint@v6.22.0 + uses: ansible/ansible-lint@main with: args: --config=.config/ansible-lint.yml From 3cd61aaccc520750e53d8156217bdc120c55318e Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:17:45 +0530 Subject: [PATCH 38/48] Update ansible-lint.yml --- .config/requirements.yml | 25 +++++++++++++++++++++++++ .github/workflows/ansible-lint.yml | 3 +-- 2 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 .config/requirements.yml diff --git a/.config/requirements.yml b/.config/requirements.yml new file mode 100644 index 000000000..a2a15f7b3 --- /dev/null +++ b/.config/requirements.yml @@ -0,0 +1,25 @@ +--- +collections: + - name: ansible.utils + version: 5.1.1 + - name: community.crypto + version: 2.22.0 + - name: community.docker + version: 3.12.1 + - name: community.general + version: 9.4.0 + - name: community.grafana + version: 2.1.0 + - name: community.mysql + version: 3.10.3 + - name: community.postgresql + version: 3.5.0 + - name: dellemc.os10 + version: 1.1.1 + - name: dellemc.openmanage + version: 9.6.0 + - name: kubernetes.core + version: 5.0.0 + - name: https://github.com/kubernetes-sigs/kubespray + type: git + version: v2.25.0 diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index e3a4ff64e..250f51430 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -31,9 +31,8 @@ jobs: run: | python3 -m pip install --upgrade pip pip install ansible - ansible-galaxy collection install community.general - name: Run ansible-lint uses: ansible/ansible-lint@main with: - args: --config=.config/ansible-lint.yml + args: --config=.config/ansible-lint.yml -r .config/requirements.yml From e0d10a04bba1252c1386d5ee552ebf7861064e72 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:24:51 +0530 Subject: [PATCH 39/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 250f51430..b31d6ae1e 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -33,6 +33,6 @@ jobs: pip install ansible - name: Run ansible-lint - uses: ansible/ansible-lint@main + uses: ansible/ansible-lint@v6.22.0 with: args: --config=.config/ansible-lint.yml -r .config/requirements.yml From 4b24ff5be1d39a43c613948cecf3bd2274292d09 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:31:55 +0530 Subject: [PATCH 40/48] Update ansible-lint.yml --- .config/requirements.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.config/requirements.yml b/.config/requirements.yml index a2a15f7b3..af0f5f004 100644 --- a/.config/requirements.yml +++ b/.config/requirements.yml @@ -23,3 +23,4 @@ collections: - name: https://github.com/kubernetes-sigs/kubespray type: git version: v2.25.0 + - name: kubernetes_sigs.kubespray From d0e3298d4d454680225490282973c408a2afe6e5 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:37:19 +0530 Subject: [PATCH 41/48] Update ansible-lint.yml --- .config/requirements.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.config/requirements.yml b/.config/requirements.yml index af0f5f004..feb7408a1 100644 --- a/.config/requirements.yml +++ b/.config/requirements.yml @@ -20,7 +20,5 @@ collections: version: 9.6.0 - name: kubernetes.core version: 5.0.0 - - name: https://github.com/kubernetes-sigs/kubespray - type: git - version: v2.25.0 - name: kubernetes_sigs.kubespray + version: v2.25.0 From d49284d42b3b92ed6d314c65b1dfd5b48be3cd30 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:42:56 +0530 Subject: [PATCH 42/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index b31d6ae1e..5415da262 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -32,7 +32,10 @@ jobs: python3 -m pip install --upgrade pip pip install ansible + - name: Install Ansible collections + run: ansible-galaxy collection install -r .config/requirements.yml + - name: Run ansible-lint uses: ansible/ansible-lint@v6.22.0 with: - args: --config=.config/ansible-lint.yml -r .config/requirements.yml + args: --config=.config/ansible-lint.yml From a6f14772c41851b6499fa43335d48dad39fd01ba Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:44:41 +0530 Subject: [PATCH 43/48] Update ansible-lint.yml --- .config/requirements.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.config/requirements.yml b/.config/requirements.yml index feb7408a1..af0f5f004 100644 --- a/.config/requirements.yml +++ b/.config/requirements.yml @@ -20,5 +20,7 @@ collections: version: 9.6.0 - name: kubernetes.core version: 5.0.0 - - name: kubernetes_sigs.kubespray + - name: https://github.com/kubernetes-sigs/kubespray + type: git version: v2.25.0 + - name: kubernetes_sigs.kubespray From eb8a7f41b63e777f89136839dd1f50ac0c5271ed Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:45:05 +0530 Subject: [PATCH 44/48] Update ansible-lint.yml --- .config/requirements.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.config/requirements.yml b/.config/requirements.yml index af0f5f004..a2a15f7b3 100644 --- a/.config/requirements.yml +++ b/.config/requirements.yml @@ -23,4 +23,3 @@ collections: - name: https://github.com/kubernetes-sigs/kubespray type: git version: v2.25.0 - - name: kubernetes_sigs.kubespray From 92c1dd6baa116b4c340dc04d10b3d64858ef26a6 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:49:58 +0530 Subject: [PATCH 45/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index b79111adc..378415690 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -18,6 +18,7 @@ exclude_paths: - input/ - platforms/ - examples/ + - $$VIRTUAL_ENV/ansible_collections/ - .ansible-lint.yml - .readthedocs.yaml From a7db6bcac30ca3f5bd95ab09df7c8b1f8790fe59 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 11:58:37 +0530 Subject: [PATCH 46/48] Update ansible-lint.yml --- .github/workflows/ansible-lint.yml | 4 ++-- requirements.yml | 25 +++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 2 deletions(-) create mode 100644 requirements.yml diff --git a/.github/workflows/ansible-lint.yml b/.github/workflows/ansible-lint.yml index 5415da262..87dc5e7c4 100644 --- a/.github/workflows/ansible-lint.yml +++ b/.github/workflows/ansible-lint.yml @@ -32,8 +32,8 @@ jobs: python3 -m pip install --upgrade pip pip install ansible - - name: Install Ansible collections - run: ansible-galaxy collection install -r .config/requirements.yml + # - name: Install Ansible collections + # run: ansible-galaxy collection install -r .config/requirements.yml - name: Run ansible-lint uses: ansible/ansible-lint@v6.22.0 diff --git a/requirements.yml b/requirements.yml new file mode 100644 index 000000000..a2a15f7b3 --- /dev/null +++ b/requirements.yml @@ -0,0 +1,25 @@ +--- +collections: + - name: ansible.utils + version: 5.1.1 + - name: community.crypto + version: 2.22.0 + - name: community.docker + version: 3.12.1 + - name: community.general + version: 9.4.0 + - name: community.grafana + version: 2.1.0 + - name: community.mysql + version: 3.10.3 + - name: community.postgresql + version: 3.5.0 + - name: dellemc.os10 + version: 1.1.1 + - name: dellemc.openmanage + version: 9.6.0 + - name: kubernetes.core + version: 5.0.0 + - name: https://github.com/kubernetes-sigs/kubespray + type: git + version: v2.25.0 From 57af672fd4cb3b3ec1052c114b64d40078072fd0 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Thu, 30 Jan 2025 12:06:22 +0530 Subject: [PATCH 47/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 378415690..6666cb1f1 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -3,9 +3,9 @@ exclude_paths: - .git/ - .github/ - accelerator/tests/ - - network/tests/ + - network/ - provision/tests/ - - scheduler/tests/ + - scheduler/ - security/tests/ - storage/tests/ - test/ From 1a4af55b9486b625a8cc23e9168db05d3be769e3 Mon Sep 17 00:00:00 2001 From: aditya-deshpande Date: Fri, 31 Jan 2025 11:30:14 +0530 Subject: [PATCH 48/48] Update ansible-lint.yml --- .config/ansible-lint.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.config/ansible-lint.yml b/.config/ansible-lint.yml index 6666cb1f1..7009e4ada 100644 --- a/.config/ansible-lint.yml +++ b/.config/ansible-lint.yml @@ -18,7 +18,6 @@ exclude_paths: - input/ - platforms/ - examples/ - - $$VIRTUAL_ENV/ansible_collections/ - .ansible-lint.yml - .readthedocs.yaml