Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the version of the webapi instance configured #15

Open
bhermann opened this issue May 4, 2018 · 5 comments
Open

Show the version of the webapi instance configured #15

bhermann opened this issue May 4, 2018 · 5 comments

Comments

@bhermann
Copy link
Member

bhermann commented May 4, 2018

As a authenticated user, I would like to see the version of the webapi instance running for each configured instance.

@janniclas
Copy link
Contributor

@johannesduesing I believe this is desirable for every instance as far as it provides a version, so we might want to extend our instance model to contain a version string? would come in handy to differentiate between possibly incompatible instances too (for example you can only match web apis and web apps with compatible versions).

@johannesduesing
Copy link
Contributor

Sounds like a good idea to me. There are two possible ways of doing this: Either we add a version attribute to the instance model, or Delphi Management just queries the components, since all of them provide an GET /version endpoint.
The former solution does require us to change all components again, since the data model changes, but it would allow us to also account for incompatible versions in the matching process.
The latter solution is easy to implement, but does not provide any other functionality besides displaying a version string.

@janniclas @bhermann what do you think ?

@bhermann
Copy link
Member Author

bhermann commented Jan 4, 2019

I would go with the latter solution. In the matching process you can easily add the call to the endpoint if necessary. For now, I would disregard the problem of incompatible versions.

@bhermann
Copy link
Member Author

@johannesduesing Is this still open?

@johannesduesing
Copy link
Contributor

I think it is, i can't find an implementation in the backend. Do you want me to take this on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants