Skip to content

Commit

Permalink
feat: add ability to configure sigmax return state
Browse files Browse the repository at this point in the history
  • Loading branch information
bartjkdp committed Dec 31, 2024
1 parent 007db40 commit fa8aabd
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import logging
import re

from django.conf import settings
from django.core.exceptions import ValidationError
from django.shortcuts import render
from lxml import etree
Expand Down Expand Up @@ -105,9 +106,20 @@ def _update_status_actualiseerZaakstatus_Lk01(signal, request_data):
Note: this is the happy flow, only happens when the Signal was in the
expected state in SIA --- else see _add_note_actualiseerZaakstatus_Lk01.
"""
status_text = _get_status_text_actualiseerZaakstatus_Lk01(request_data)
resultaat_text = request_data.get('resultaat', '').strip()

if settings.SIGMAX_END_STATE_IS_AFGEHANDELD and resultaat_text == 'afgerond':
set_status_to_afgehandeld = True
note_text = _get_status_text_actualiseerZaakstatus_Lk01(request_data)
status_text = settings.SIGMAX_END_STATE_IS_AFGEHANDELD_STATUS_TEXT
else:
set_status_to_afgehandeld = False
note_text = None
status_text = _get_status_text_actualiseerZaakstatus_Lk01(request_data)

status_data = {
'state': workflow.AFGEHANDELD_EXTERN,
'state': workflow.AFGEHANDELD if set_status_to_afgehandeld else workflow.AFGEHANDELD_EXTERN,
'send_email': True if set_status_to_afgehandeld else False,
'text': status_text,
'extra_properties': {
'sigmax_datum_afgehandeld': request_data['datum_afgehandeld'],
Expand All @@ -116,6 +128,10 @@ def _update_status_actualiseerZaakstatus_Lk01(signal, request_data):
}
}

if note_text:
note_data = {'text': note_text}
Signal.actions.create_note(note_data, signal)

# We let exceptions bubble up (must lead to a error message to CityControl).
Signal.actions.update_status(data=status_data, signal=signal)

Expand Down
1 change: 1 addition & 0 deletions app/signals/apps/signals/workflow.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@
],
VERZONDEN: [
AFGEHANDELD_EXTERN,
AFGEHANDELD,
GEANNULEERD, # SIG-2987
],
VERZENDEN_MISLUKT: [
Expand Down
2 changes: 2 additions & 0 deletions app/signals/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,8 @@ def is_super_user(user) -> bool:
SIGMAX_CLIENT_CERT: str | None = os.getenv('SIGMAX_CLIENT_CERT', None)
SIGMAX_CLIENT_KEY: str | None = os.getenv('SIGMAX_CLIENT_KEY', None)
SIGMAX_SEND_FAIL_TIMEOUT_MINUTES: str | int = os.getenv('SIGMAX_SEND_FAIL_TIMEOUT_MINUTES', 60*24) # noqa Default is 24hrs.
SIGMAX_END_STATE_IS_AFGEHANDELD: bool = os.getenv('SIGMAX_END_STATE_IS_AFGEHANDELD', False) in TRUE_VALUES
SIGMAX_END_STATE_IS_AFGEHANDELD_STATUS_TEXT: str = os.getenv('SIGMAX_END_STATE_IS_AFGEHANDELD_STATUS_TEXT', 'We hebben uw melding opgelost. Bedankt voor het doorgeven!')

# Child settings
SIGNAL_MAX_NUMBER_OF_CHILDREN: int = 10
Expand Down

0 comments on commit fa8aabd

Please sign in to comment.