Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing TVL on cbETH and wstETH #1653

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix missing TVL on cbETH and wstETH #1653

merged 1 commit into from
Nov 14, 2024

Conversation

DannyDelott
Copy link
Contributor

Closes #1652

These two pools use a baseTokenFallback to calculate TVL, but we were calling the priceOracle function with the poolConfig's baseToken which is set to the zero address.

Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: aef8cc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 4:40pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 4:40pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Nov 14, 2024 4:40pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Nov 14, 2024 4:40pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Nov 14, 2024 4:40pm
testnet-v1 ⬜️ Ignored (Inspect) Nov 14, 2024 4:40pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Nov 14, 2024 4:40pm
trading-competition ⬜️ Ignored (Inspect) Nov 14, 2024 4:40pm

@DannyDelott DannyDelott changed the title Don't use baseToken from poolConfig Fix missing TVL on cbETH and wstETH Nov 14, 2024
@DannyDelott DannyDelott merged commit a24d82b into main Nov 14, 2024
14 checks passed
@DannyDelott DannyDelott deleted the danny-1652-fix-tvl branch November 14, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app-staging: TVL shows 0 for some markets
1 participant