Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show rewards in portfolio #1661

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Show rewards in portfolio #1661

merged 4 commits into from
Nov 20, 2024

Conversation

DannyDelott
Copy link
Contributor

Using dummy data for now based on the data schema we chatted about last week.

image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: aab44f7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdrive-mainnet-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:28pm
hyperdrive-sepolia-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:28pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
hyperdrive-js ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 9:28pm
hyperdrive-mainnet-production ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 9:28pm
hyperdrive-sepolia-production ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 9:28pm
testnet-v1 ⬜️ Ignored (Inspect) Nov 19, 2024 9:28pm
testnet-v1.0.6 ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 9:28pm
trading-competition ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 9:28pm

ryangoree
ryangoree approved these changes Nov 19, 2024
View reviewed changes
apps/hyperdrive-trading/src/ui/portfolio/PortfolioTableHeading.tsx Outdated
Comment on lines 12 to 13
<div className="flex items-center gap-1">
<div className="font-chakraPetch text-h4">{leftElement}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these divs can be merged

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

apps/hyperdrive-trading/src/ui/portfolio/PositionTableHeading.tsx Outdated
</div>
<PortfolioTableHeading
leftElement={
<div className="flex items-center gap-1">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the divs are merged in the PortfolioTableHeading, then this one could be removed.

apps/hyperdrive-trading/src/ui/portfolio/rewards/RewardsTableDesktop.tsx Outdated
Comment on lines 42 to 44
className={classNames(
"relative z-10 text-sm font-normal text-neutral-content/70",
)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary classNames

@DannyDelott DannyDelott merged commit f2e2a9f into main Nov 20, 2024
15 checks passed
@DannyDelott DannyDelott deleted the danny-show-rewards-portfolio branch November 20, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryangoree ryangoree ryangoree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DannyDelott @ryangoree