Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup #967

Merged
merged 7 commits into from
Apr 16, 2024
Merged

code cleanup #967

merged 7 commits into from
Apr 16, 2024

Conversation

dpaiton
Copy link
Contributor

@dpaiton dpaiton commented Apr 12, 2024 •
edited
Loading

Resolved Issues

no issues

Description

  • removes unused imports
  • uses lib calc rate function instead of duplicated fn in targeted_long
  • moves reserves_given_rate into lib for use by targeted short
  • updates docstrings, var names, & fn names to be more clear

Review Checklists

Please check each item before approving the pull request. While going
through the checklist, it is recommended to leave comments on items that are
referenced in the checklist to make sure that they are reviewed. If there are
multiple reviewers, copy the checklists into sections titled ## [Reviewer Name].
If the PR doesn't touch Solidity and/or Rust, the corresponding checklist can
be removed.

[[Reviewer Name]]

Rust

  • Testing
    • Are there new or updated unit or integration tests?
    • Do the tests cover the happy paths?
    • Do the tests cover the unhappy paths?
    • Are there an adequate number of fuzz tests to ensure that we are
      covering the full input space?
    • If matching Solidity behavior, are there differential fuzz tests that
      ensure that Rust matches Solidity?

@dpaiton dpaiton changed the title Dpaiton/fixups code cleanup Apr 12, 2024
ryangoree
ryangoree approved these changes Apr 15, 2024
View reviewed changes
dpaiton and others added 7 commits April 15, 2024 16:25
@dpaiton
removes redundant import
cdef68d
@dpaiton
moves long functions
1560f32 
Functions that need to be shared by targeted_short are moved to a more
accessile location.
Functions that hae duplicate purpose are consolidated.
@dpaiton
adds calc_rate_after_short
b756afe
@dpaiton
fixes return types
66c44e4
@dpaiton @ryangoree
fix subscript
1b446d6 
Co-authored-by: Ryan Goree <[email protected]>
@dpaiton @ryangoree
update docstring
34fc8fa 
Co-authored-by: Ryan Goree <[email protected]>
@dpaiton
fixes comment
295800e
@dpaiton dpaiton enabled auto-merge April 15, 2024 23:26
@dpaiton dpaiton added this pull request to the merge queue Apr 15, 2024
Merged via the queue into main with commit 3360daa Apr 16, 2024
36 checks passed
@dpaiton dpaiton deleted the dpaiton/fixups branch April 16, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryangoree ryangoree ryangoree approved these changes

@jalextowle jalextowle Awaiting requested review from jalextowle jalextowle is a code owner

@jrhea jrhea Awaiting requested review from jrhea jrhea is a code owner

@mcclurejt mcclurejt Awaiting requested review from mcclurejt

@slundqui slundqui Awaiting requested review from slundqui

@sentilesdal sentilesdal Awaiting requested review from sentilesdal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpaiton @ryangoree