-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit testing best practices #1381
Conversation
Preview Site AvailableCongratulations! The automatic build has completed successfully. Important: Make sure to inspect your changes at the preview site. Detected modified urls: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Line 238 should be replaced with:
script with --console_log_threshold DEBUG
for verbose output.
Preview Site AvailableCongratulations! The automatic build has completed successfully. Important: Make sure to inspect your changes at the preview site. Detected modified urls: |
Preview Site AvailableCongratulations! The automatic build has completed successfully. Important: Make sure to inspect your changes at the preview site. Detected modified urls: |
Preview Site AvailableCongratulations! The automatic build has completed successfully. Important: Make sure to inspect your changes at the preview site. Detected modified urls: |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you'd like to keep it open, please leave a comment with the status of the PR. Thank you for your contribution! |
This pull request has been automatically closed because there has been no activity for 21 days. Please feel free to reopen it (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
No description provided.