Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing best practices #1381

Closed
wants to merge 9 commits into from
Closed

Unit testing best practices #1381

wants to merge 9 commits into from

Conversation

dorschw
Copy link
Contributor

@dorschw dorschw commented Aug 14, 2023

No description provided.

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1381-x9pednua.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

Copy link
Contributor

@tkatzir tkatzir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Line 238 should be replaced with:
script with --console_log_threshold DEBUG for verbose output.

docs/integrations/unit-testing.md Outdated Show resolved Hide resolved
@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1381-x9pednua.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1381-x9pednua.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@dorschw dorschw marked this pull request as ready for review August 21, 2023 14:58
@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1381-x9pednua.web.app


Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

@dorschw dorschw enabled auto-merge (squash) August 21, 2023 15:08
@dorschw dorschw disabled auto-merge August 21, 2023 15:09
@stale
Copy link

stale bot commented Sep 7, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs.

If you'd like to keep it open, please leave a comment with the status of the PR.

Thank you for your contribution!

@stale stale bot added the stale label Sep 7, 2023
@stale
Copy link

stale bot commented Sep 14, 2023

This pull request has been automatically closed because there has been no activity for 21 days.

Please feel free to reopen it (or open a new one) if the proposed change is still appropriate.

Thank you for your contribution!

@stale stale bot closed this Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants