Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mishandled HTML markup in slides' title #96

Open
altblue opened this issue Jan 25, 2023 · 0 comments
Open

Mishandled HTML markup in slides' title #96

altblue opened this issue Jan 25, 2023 · 0 comments

Comments

@altblue
Copy link

altblue commented Jan 25, 2023

Selected title ‒both through titleSelector and from data-menu-title‒ is considered plain text, but it's used as HTML (create()), leading to unexpected results.

Demo: https://codepen.io/altblue/pen/BaPrXbv

Looking at create() code, I see its last argument, content, being used as HTML (the innerHTML line), while all create() calls seem to feed plain text. If this impression is right, then a quick fix might be replacing innerHTML with an append() call.

OTOH, I see in the useTextContentForMissingTitles code path some HTML markup escaping code: if refactored, that might be use to prepare content on the calling create() side).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant